简体   繁体   中英

VBA/Excel - Copy worksheet to another workbook (Replace existing values)

I am trying to copy the values from one sheet, into another workbooks sheet. However I can't get Excel to actually paste the values to the other workbook.

This my code.

Sub ReadDataFromCloseFile()
    On Error GoTo ErrHandler
    Application.ScreenUpdating = False

    Dim src As Workbook ' SOURCE
    Dim currentWbk As Workbook ' WORKBOOK TO PASTE VALUES TO

    Set src = openDataFile
    Set currentWbk = ActiveWorkbook

     'Clear existing data
     currentWbk.Sheets(1).UsedRange.ClearContents

     src.Sheets(1).Copy After:=currentWbk.Sheets(1)

    ' CLOSE THE SOURCE FILE.
     src.Close False  ' FALSE - DON'T SAVE THE SOURCE FILE.
     Set src = Nothing

ErrHandler:
    Application.EnableEvents = True
    Application.ScreenUpdating = True
End Sub

And below is the function openDataFile which is used to get the source workbok (File Dialog):

Function openDataFile() As Workbook
'
Dim wb            As Workbook
Dim filename      As String
Dim fd            As FileDialog

Set fd = Application.FileDialog(msoFileDialogFilePicker)
fd.AllowMultiSelect = False
fd.Title = "Select the file to extract data"

' Optional properties: Add filters
fd.Filters.Clear
fd.Filters.Add "Excel files", "*.xls*" ' show Excel file extensions only

' means success opening the FileDialog
If fd.Show = -1 Then
    filename = fd.SelectedItems(1)
End If

' error handling if the user didn't select any file
If filename = "" Then
    MsgBox "No Excel file was selected !", vbExclamation, "Warning"
    End
End If

Set openDataFile = Workbooks.Open(filename)

End Function

When I try to run my Sub, it opens the src file and just stops there. No values are copied and pasted to my currentWbk

What am I doing wrong?

Maybe my sub will help u

Public Sub CopyData()
    Dim wb As Workbook
    Set wb = GetFile("Get book") 'U need use your  openDataFile  here
    Dim wsSource As Worksheet
    Set wsSource = wb.Worksheets("Data")'enter your name of ws

    Dim ws As Worksheet
    Set ws = ThisWorkbook.Worksheets.Add

    wsSource.Cells.Copy ws.Cells
    wb.Close False

End Sub

The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.

 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM