Swift search bar(controller) memory leaks

Question

I have main screen, with a button on which I segue to searchVC screen.I have a navigation controller between them, in searchVC there are searchController and searchBar .

Problem :I need to activate search when screen appears, but searchBar activation(tap or becomeFirstResponder() ) causes memory leaks ( image below )

I tried to remove delegates and the problem disappears, but I need to know when cancel button pressed to segue/dismiss to mainVC

Code :tableView for results, resultView with label for empty results

class SearchViewController: UIViewController,UISearchBarDelegate,UISearchControllerDelegate {
@IBOutlet weak var tableView: UITableView!
@IBOutlet weak var resultView: ResultView!

let searchController = UISearchController(searchResultsController: nil)

var filteredSongs = [SongListModel]()
var songs = SongListModel.fetchSongs()


override func viewDidLoad() {
    super.viewDidLoad()

    searchController.searchResultsUpdater = self
    searchController.obscuresBackgroundDuringPresentation = false
    searchController.searchBar.placeholder = "Search songs"
    if #available(iOS 11.0, *) {
        navigationItem.titleView = searchController.searchBar
        navigationItem.hidesSearchBarWhenScrolling = false
        //            navigationController?.navigationBar.topItem?.searchController = searchController
        //            navigationItem.titleView?.isHidden = true
        searchController.dimsBackgroundDuringPresentation = false
        searchController.hidesNavigationBarDuringPresentation = false
    } else {
        tableView.tableHeaderView = searchController.searchBar
    }
    searchController.searchBar.showsCancelButton = true
    searchController.definesPresentationContext = true

    searchController.searchBar.sizeToFit()
    searchController.delegate = self
    searchController.searchBar.delegate = self

    tableView.keyboardDismissMode = .interactive
}


override func viewDidAppear(_ animated: Bool) {
    super.viewDidAppear(animated)
    delay(0.1) { [unowned self] in
        self.searchController.searchBar.becomeFirstResponder()
    }


}
func delay(_ delay: Double, closure: @escaping ()->()) {
    let when = DispatchTime.now() + delay
    DispatchQueue.main.asyncAfter(deadline: when, execute: closure)
}


func scrollViewWillBeginDragging(_ scrollView: UIScrollView) {
    searchController.searchBar.resignFirstResponder()
}

func searchBarIsEmpty() -> Bool {
    // Returns true if the text is empty or nil
    return searchController.searchBar.text?.isEmpty ?? true
}

func filterContentForSearchText(_ searchText: String, scope: String = "All") {
    filteredSongs = songs.filter({( song : SongListModel) -> Bool in
        return song.musicFileName.lowercased().contains(searchText.lowercased())
    })

    tableView.reloadData()
}

func isFiltering() -> Bool {
    return searchController.isActive && !searchBarIsEmpty()
}

func searchBarCancelButtonClicked(_ searchBar: UISearchBar) {
    searchController.searchBar.endEditing(true)
    searchController.searchBar.resignFirstResponder()
    //        searchController.searchBar.delegate = nil
    //        searchController.searchResultsUpdater = nil


    dismiss(animated: true, completion: nil)
}


// MARK: - Navigation

override func prepare(for segue: UIStoryboardSegue, sender: Any?) {
    if segue.identifier == "PlayTilesSegue", let destinationVC = segue.destination as? TilesViewController, let selectedIndex = tableView.indexPathForSelectedRow?.row {
        let song: SongListModel
        if isFiltering() {
            song = filteredSongs[selectedIndex]
        } else {
            song = songs[selectedIndex]
        }
        destinationVC.songFileName = song.musicFileName
        navigationController?.setNavigationBarHidden(true, animated: false)
    }
}
}
extension SearchViewController: UITableViewDelegate,UITableViewDataSource {


func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
    if isFiltering() {
        resultView.setIsFilteringToShow(filteredItemCount: filteredSongs.count, of: songs.count)
        return filteredSongs.count
    }

    resultView.setNotFiltering()
    return songs.count

}

func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
    let cell = tableView.dequeueReusableCell(withIdentifier: "filteredCell", for: indexPath) as! FilteredSongCell

    let song: SongListModel

    if isFiltering() {
        song = filteredSongs[indexPath.row]
    } else {
        song = songs[indexPath.row]
    }

    cell.listenSongButton.setBackgroundImage(UIImage(named: "playback"), for: .normal)
    cell.filteredAuthorNameLabel.text = song.authorName
    cell.filteredSongNameLabel.text = song.songName
    cell.playGameButton.setTitle(song.playButton.rawValue, for: .normal)

    return cell
}

func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
    performSegue(withIdentifier: "PlayTilesSegue", sender: indexPath)
    tableView.deselectRow(at: indexPath, animated: true)

}



}

extension SearchViewController: UISearchResultsUpdating {
    func updateSearchResults(for searchController: UISearchController) {
        filterContentForSearchText(searchController.searchBar.text!)
    }
}

Image memory leaks

Answer 1

You need to set the UISearchController searchBar's delegate. Once you have done this, the addition of the delegate method searchBarCancelButtonClicked: will properly be called.

Here it is.