简体   繁体   中英

Image element becoming null on src change? Slideshow

Working on building a library, trying to put in a fading image slider, it shows the first image, but then when it tries to change I get TypeError: document.querySelector(...) is null. Any help would be great!

 export let styl = (function() {
  let slideIndex = 0;
  return {

    simpleSlideShow: function() {
      //automatic Slider
      let i;
      let slides = document.getElementsByClassName("mySlides");
      console.log("Image change");
      for (i = 0; i < slides.length; i++) {
        slides[i].style.display = "none";
      }
      slideIndex++;
      if (slideIndex > slides.length) {
        slideIndex = 1;
      }
      slides[slideIndex - 1].style.display = "block";
    },
    slideShowImageSetup: function(timeDelay, id, images) {
      //Building HTML with given array of images
      let i;
      for (i = 0; i < images.length; i++) {
        let elem = document.createElement("img");
        elem.setAttribute("alt", "image");
        elem.setAttribute("src", images[i]);
        elem.setAttribute("class", "mySlides");
        document.querySelector(id).appendChild(elem);
      }
      setTimeout(styl.simpleSlideShow, 1);
      setInterval(styl.simpleSlideShow, timeDelay);
      return 1;
    },
    fadingSlideShow: function(id, images) {
      document.querySelector(id).className += "fadeOut";
      setTimeout(function() {
        document.querySelector(id).src = images[slideIndex];
        document.querySelector(id).className = "";
        slideIndex++;
        if (slideIndex == images.length) {
          slideIndex = 0;
        }
        setTimeout(styl.fadingSlideShow(id, images), 3000);
      }, 1000);
    },
  };
})();

Where I'm calling the function

let images = [
  "https://cdn141.picsart.com/297231911148201.jpg?c256x256",
  "https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcSQIfOEjoaYJNDHGmdgRa8EQp50VCicpK0R_0QpZLftE2zzgJky"
];

styl.fadingSlideShow("#slider", images);
<img id="slider"></img>

css that makes the fade effect

#slider {
    opacity: 1;
    transition: opacity 3s;
}

#slider.fadeOut {
    opacity: 0;
}

Your second setTimeout is not sending in the id or images to styl.fadingSlideShow.

setTimeout(function(){styl.fadingSlideShow(id, images)}, 3000);

Also, put the second setTimeout inside the first one.

The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.

 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM