Trying to use React useState to change Sound Banks on a Drum Machine but changing banks function is running twice

Question

I'm creating a drum machine using React. So far I've gotten everything to work, but now that I've tried implementing a second sound bank I've run into some problems with the event listeners.

So far, changing banks using handleclick works absolutely fine. However, when I use event listeners for some reason both bank1 and bank2 audios are playing over the top ofeach other.

I have no idea where I'm going wrong with my logic.

Any help would be greatly appreciated

Here's my code so far (apologies for messy code).

    import React, { useState, useEffect} from 'react';

const audioSamples = {
  bank1:{
  q: new Audio("http://dight310.byu.edu/media/audio/FreeLoops.com/3/3/Free%20Kick%20Sample%208-900-Free-Loops.com.mp3"),
  w: new Audio("http://www.denhaku.com/r_box/sr16/sr16sd/alloysnr.wav"),
  e: new Audio("http://dight310.byu.edu/media/audio/FreeLoops.com/5/5/Long%20Open%20Hi%20Hat%20002-1653-Free-Loops.com.mp3"),
  a: new Audio("http://dight310.byu.edu/media/audio/FreeLoops.com/4/4/Korg%20Ride%20Cymbal%202-2526-Free-Loops.com.mp3"),
  s: new Audio("http://electrongate.com/dmxfiles/DXCRASH.wav"),
  d: new Audio("http://cd.textfiles.com/10000soundssongs/WAV/COWBELL1.WAV")
  },
  bank2:{
    q: new Audio("http://cd.textfiles.com/10000soundssongs/WAV/EERIE_1.WAV"),
    w: new Audio("http://www.denhaku.com/r_box/linn/congal.wav"),
    e: new Audio("http://electrongate.com/dmxfiles/conga.wav"),
    a: new Audio("http://dight310.byu.edu/media/audio/FreeLoops.com/4/4/Korg%20Ride%20Cymbal%202-2526-Free-Loops.com.mp3"),
    s: new Audio("http://electrongate.com/dmxfiles/DXCRASH.wav"),
    d: new Audio("http://cd.textfiles.com/10000soundssongs/WAV/COWBELL1.WAV")
    }
}
   
function App() {

  const [banknum, setBanknum] = useState(1); 
 
  function changeBank() {
    setBanknum(prevBanknum => prevBanknum === 1 ? prevBanknum = 2 : prevBanknum = 1) 
  }
  console.log(banknum)
  document.addEventListener('keydown', function(e) {
 
    if(banknum === 1 && audioSamples.bank1[e.key] ){
      audioSamples.bank1[e.key].load()
      audioSamples.bank1[e.key].play()
      }
      else if (banknum === 2 && audioSamples.bank1[e.key]) {
      audioSamples.bank2[e.key].load()
      audioSamples.bank2[e.key].play()
     }
      console.log(banknum)
      }
   
    )

  

  function handleClick(e) {
    if(banknum === 1){
    audioSamples.bank1[e.target.id].play()
    }
    else if (banknum === 2) {audioSamples.bank2[e.target.id].play() }
    }

  return (
    <div id="DrumMachine" className="App" >
      <button id="q" onClick={handleClick} >Q</button>
      <button id="w" onClick={handleClick}>W</button>
      <button id="e" onClick={handleClick}>E</button>
      <button id="a" onClick={handleClick}>A</button>
      <button id="s" onClick={handleClick}>S</button>
      <button id="d" onClick={handleClick}>D</button>
      <button id ="banks" onClick={changeBank}>Change Bank
      </button>
    </div>
  );
}
export default App;

Answer 1

AddEventListener is rendering twice in your case.

Do this instead.

  const handleEvent = useCallback((e) => {
    if (banknum === 1 && audioSamples.bank1[e.key]) {
      audioSamples.bank1[e.key].load();
      audioSamples.bank1[e.key].play();
    } else if (banknum === 2 && audioSamples.bank2[e.key]) {
      audioSamples.bank2[e.key].load();
      audioSamples.bank2[e.key].play();
    }
  }, [banknum])

  useEffect(() => {
    document.addEventListener("keydown", handleEvent);
    return () => {
      document.removeEventListener("keydown", handleEvent);
    }
  }, [banknum, handleEvent]);

Working sandbox here .