When I delete cell from tableview cells that are not deleted are duplicated SWIFT

Question

I have a tableView which I created with firebase data.

Here is my load func :

  var reservationList = [UserModal]()

 private func loadposts() {
        reservationList = []
        activityIndicator.startAnimating()
        
        Database.database().reference().child("BookReservations").observe(.value) { snapshot in
         
            for case let child as DataSnapshot in snapshot.children {
                guard let dict = child.value as? [String:Any] else {
                    print("Error")
                    self.activityIndicator.stopAnimating()
                    return
                }
                let name = dict["name"] as! String
                let date = dict["date"] as? String ?? "nil"
                let book = dict["bookName"] as? String ?? "nil"
                let FullDate = dict["fullDate"] as? String ?? "nil"
                let phoneNumber = dict["phoneNumber"] as? String ?? "nil"
                
                let reservations = UserModal(name: name, dateAndTime: date, choosenBook: bookName  , phoneNumber: phoneNumber, tamRandevu: fullDate)
                self.reservationList.append(reservations)
                print(self.reservationList)
                
                self.activityIndicator.stopAnimating()
                self.tableView.reloadData()
            }
        }
    }
extension ReservationListViewController: UITableViewDelegate,UITableViewDataSource{
    func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
        return reservationList.count
    }



 func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
        let cell = tableView.dequeueReusableCell(withIdentifier: "reservationCell", for: indexPath) as! reservationCell
        cell.bookNameLabel.text = reservationList[indexPath.row].choosenBook
        cell.nameLabel.text = reservationList[indexPath.row].userName
        cell.dateAndTimeLabel.text = reservationList[indexPath.row].fullDate
        cell.phoneButton.setTitle(reservationList[indexPath.row].phoneNumber, for: .normal)
        
        return cell
    }

I can get value and show on tableView. But when I try to delete cell :

func tableView(_ tableView: UITableView, commit editingStyle: UITableViewCell.EditingStyle, forRowAt indexPath: IndexPath) {
      if editingStyle == .delete {
        
        print("Deleted")
        activityIndicator.startAnimating()
        
        let reservationTime = reservationList[indexPath.row].fullDate ?? "nil"
            print(reservationTime)
        
            if reservationTime != "nil" {
                
                let stationsRef = database.child("BookReservations") 
               
                print(reservationList.count)

                

                  print("Before deleting Count of reservation list : \(reservationList.count)")
            
            reservationList.forEach { (UserModal) in
                print(UserModal.name)
            }
            stationsRef.child(reservationTime).setValue(nil)
          
            reservationList.remove(at: indexPath.row)
            tableView.deleteRows(at: [indexPath], with: .fade)
            
          
            
           
         
            print("After deleting Count of reservation list : \(reservationList.count)")
          
            reservationList.forEach { (UserModal) in
                print(UserModal.name)
            }
                
                activityIndicator.stopAnimating()
               
               
            }else{
              
                activityIndicator.stopAnimating()
                print("no reservation found.")
            }
        
      }
    }

I can succesfully delete data from firebase real time database. But when I delete data , If there is more than one data in the tableView, the non-deleted data will repeat itself. I try to check my array count it seems good when delete count is decreasing.. I try tableview reload, begin updates and and updates but nothing works. Only works when I refresh tableview with refresh method. This is my print outputs :

Before deleting Count of reservation list : 2 Optional("yakalaaa") Optional("xyzzz") After deleting Count of reservation list : 1 Optional("yakalaaa")

this is my tableView which I load with firebase data : enter image description here

I delete second cell :

enter image description here

and this is the problem :

enter image description here

any suggestions ?

Answer 1

the problem is with these lines:

tableView.beginUpdates()
reservationList.remove(at: indexPath.row)
tableView.deleteRows(at: [indexPath], with: .bottom)
tableView.endUpdates()

just use instead

reservationList.remove(at: indexPath.row)
tableView.reloadData()