简体   繁体   中英

Bcrypt compare issue nodejs

I've got myself two functions, first is responsible for adding a user model to database and second one for comparing passwords. But.. comparing never works..

module.exports.signup = function (req, res) {
if (req.body == null) {
    res.status(400);
    return res.end('Bad juju');
} else {
    let exists;
    User.findOne({ username: req.body.username }),
        (err, doc) => {
            if (doc) {
                exists = true;
                return;
            }
        };
    if (exists) {
        res.setHeader('user-exists', true);
        res.redirect('/signup');
    } else {
        bcrypt.hash(req.body.password, 10, function (hashE, hash) {
            if (hashE) {
                throw hashE;
            }
            new User({
                username: req.body.username,
                email: req.body.email,
                password: hash,
            }).save();
        });
        return res.redirect('/login');
    }
}
};

module.exports.login = function (req, res) {
if (req.body.tosignup) {
    return res.redirect('/signup');
}
if (req.body == null) {
    res.status(400);
    return res.end('Bad request');
} else {
    User.findOne({ username: req.body.username }, (err, doc) => {
        if (err) throw console.log(err);
        console.log(doc.password);
        console.log(req.body.password);
        bcrypt.hash(req.body.password, 10, (err, s) => {
            console.log(s);
        });
        bcrypt.compare(req.body.password, doc.password, (err, succ) => {
            if (err) {
                throw err;
            }
            console.log(err);
            console.log(succ);
            if (succ) {
                res.setHeader('username', doc.username);
                return res.redirect('/welcome');
            } else {
                res.setHeader('password-wrong', true);
                return res.redirect('/login');
            }
        });
    });
}
};

I've looked for different sources and all of them told that this one method is the correct one, but every time I try using it, it just doesn't work

I had a similar problem using bcrypt in nodejs. To solve the problem i switched from npm bcrypt to npm bcryptjs ( https://www.npmjs.com/package/bcryptjs ) and used the following:

NPM require:

const bcrypt = require('bcryptjs');

To compare the passwords you can use the following code:

async function compareIt(password, hashedPassword) {
  const validPassword = await bcrypt.compare(password, hashedPassword);
  return validPassword;
}

compareIt(password, passwordBD).then(v => {
    if (v == true) {
        console.log("Equal");
    } else {
        console.log("Not equal");
    }
});

To hash the password you can use this function:

async function hashIt(password) {
  const salt = await bcrypt.genSalt(6);
  const hashed = await bcrypt.hash(password, salt);
  return hashed;
}

The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.

 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM