stackoom
  简体   繁体   中英

Menu doesn't close after clicking link in nav

 原文  2022-04-26 15:54:06  7   1    javascript/ jquery/ css/ onclick/ nav

Question

When I open menu in smaller resolution(mobile resolution) and click on some link from the menu its not closing, its still there the menu. Can you help me? I think there is missing something in js code but I don't know what I can write more to close menu after clicking on the link from the menu. 

 const body = document.querySelector("body"); const navbar = document.querySelector(".navbar"); const menuBtn = document.querySelector(".menu-btn"); const cancelBtn = document.querySelector(".cancel-btn"); menuBtn.onclick = () => { navbar.classList.add("show"); menuBtn.classList.add("hide"); body.classList.add("disabled"); } cancelBtn.onclick = () => { body.classList.remove("disabled"); navbar.classList.remove("show"); menuBtn.classList.remove("hide"); } window.onscroll = () => { this.scrollY > 20? navbar.classList.add("sticky"): navbar.classList.remove("sticky"); }
 @import url('https://fonts.googleapis.com/css2?family=Poppins:wght@200;300;400;500;600;700&display=swap'); * { margin: 0; padding: 0; box-sizing: border-box; font-family: 'Poppins', sans-serif; } /* custom scroll bar */::-webkit-scrollbar { width: 10px; }::-webkit-scrollbar-track { background: #f1f1f1; }::-webkit-scrollbar-thumb { background: #888; }::selection { background: rgb(0, 123, 255, 0.3); }.content { max-width: 1250px; margin: auto; padding: 0 30px; }.navbar { position: fixed; width: 100%; z-index: 2; padding: 25px 0; transition: all 0.3s ease; }.navbar.sticky { background: #1b1b1b; padding: 10px 0; box-shadow: 0px 3px 5px 0px rgba(0, 0, 0, 0.1); }.navbar.content { display: flex; align-items: center; justify-content: space-between; }.navbar.logo a { color: #fff; font-size: 30px; font-weight: 600; text-decoration: none; }.navbar.menu-list { display: inline-flex; }.menu-list li { list-style: none; }.menu-list li a { color: #fff; font-size: 18px; font-weight: 500; margin-left: 25px; text-decoration: none; transition: all 0.3s ease; }.menu-list li a:hover { color: #007bff; }.banner { background: url("banner.jpg") no-repeat; height: 100vh; background-size: cover; background-position: center; background-attachment: fixed; }.about { padding: 30px 0; }.about.title { font-size: 38px; font-weight: 700; }.about p { padding-top: 20px; text-align: justify; }.icon { color: #fff; font-size: 20px; cursor: pointer; display: none; }.menu-list.cancel-btn { position: absolute; right: 30px; top: 20px; } @media (max-width: 1230px) {.content { padding: 0 60px; } } @media (max-width: 1100px) {.content { padding: 0 40px; } } @media (max-width: 900px) {.content { padding: 0 30px; } } @media (max-width: 868px) { body.disabled { overflow: hidden; }.icon { display: block; }.icon.hide { display: none; }.navbar.menu-list { position: fixed; height: 100vh; width: 100%; max-width: 400px; left: -100%; top: 0px; display: block; padding: 40px 0; text-align: center; background: #222; transition: all 0.3s ease; }.navbar.show.menu-list { left: 0%; }.navbar.menu-list li { margin-top: 45px; }.navbar.menu-list li a { font-size: 23px; margin-left: -100%; transition: 0.6s cubic-bezier(0.68, -0.55, 0.265, 1.55); }.navbar.show.menu-list li a { margin-left: 0px; } } @media (max-width: 380px) {.navbar.logo a { font-size: 27px; } }
 <head> <meta charset="UTF-8"> <meta name="viewport" content="width=device-width, initial-scale=1.0"> <title>Sticky Navigation Bar | CodingNepal</title> <link rel="stylesheet" href="style.css"> <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.3/css/all.min.css" /> </head> <body> <nav class="navbar"> <div class="content"> <div class="logo"> <a href="#">CodingNepal</a> </div> <ul class="menu-list"> <div class="icon cancel-btn"> <i class="fas fa-times"></i> </div> <li><a href="#">Home</a></li> <li><a href="#">About</a></li> <li><a href="#">Services</a></li> <li><a href="#">Features</a></li> <li><a href="#">Contact</a></li> </ul> <div class="icon menu-btn"> <i class="fas fa-bars"></i> </div> </div> </nav> <div class="banner"></div> <div class="about"> <div class="content"> <div class="title">Responsive Sticky Navigation Menu Bar on Scroll using HTML CSS & JavaScript</div> <p>Lorem ipsum dolor sit amet, consectetur adipisicing elit. Quo impedit atque consequatur, Iusto distinctio temporibus repellendus labore odit adipisci harum ipsa beatae natus, eum eius, hic aperiam odio, Quasi molestias magnam illo voluptatem iusto ipsam blanditiis. tempore cumque reiciendis quaerat vero t.netur, sequi dolores libero voluptas vitae voluptate placeat dolorum modi ipsa nisi repellat facilis aliquam asperiores, Aut nam repellat harum quas saepe dolorum voluptates ratione. itaque consectetur explicabo a facilis rem mollitia maxime repudiandae fuga reprehenderit, odio cum incidunt labore molestiae quis non perferendis ipsam, Illum. in. deserunt, Ipsa.</p> <p>Lorem ipsum dolor sit amet, consectetur adipisicing elit, Impedit hic excepturi nobis id, eos dolor libero, nam assumenda, at culpa quos perspiciatis ratione ea modi. Natus sapiente a, explicabo sit quisquam eligendi esse provident eos enim doloremque blanditiis aut placeat veniam, libero nostrum quae. Ipsam, iste reprehenderit minima accusantium illo dolorem recusandae. ipsa autem quidem reiciendis a mollitia sit t.netur,</p> <p>Lorem ipsum dolor sit amet, consectetur adipisicing elit? Sint doloremque perspiciatis voluptate ducimus reiciendis rem expedita voluptatibus dicta harum, quo, aspernatur maiores possimus officia quod, Aliquid molestiae illo sequi, tempora perferendis at incidunt nam porro voluptatibus, iste aperiam blanditiis adipisci ducimus repellendus distinctio nostrum ipsum, Voluptas facilis cum, atque tempora magnam beatae sequi. Doloribus expedita, cupiditate quo quod nemo aliquam, mollitia cum ea nam ullam soluta temporibus. Repudiandae incidunt consequatur distinctio deleniti obcaecati sit facilis unde, quisquam veniam ad doloribus.</p> <p>Lorem ipsum dolor sit amet, consectetur adipisicing elit. Amet veniam error deleniti cum beatae non assumenda illum est dolores, possimus suscipit quibusdam eveniet id fuga dolore unde modi, sapiente voluptas. Mollitia veritatis explicabo cumque enim quia voluptates provident totam perferendis excepturi animi assumenda optio minus laudantium eveniet possimus amet blanditiis dolore in fuga atque, earum officia tempora quam similique est,</p> <p>Lorem ipsum dolor sit amet, consectetur adipisicing elit. Itaque ad sunt distinctio quidem incidunt cupiditate sequi deleniti, corrupti officia nam veritatis facilis veniam dolorum enim nisi ipsum dolor rem, Doloribus, eaque odit voluptatem iste laboriosam provident facere quo. Cum repellat pariatur, error ratione repellendus nisi quam culpa tempora facere in atque nesciunt, magni est aliquid unde soluta optio! Dolore pariatur, quaerat quo in cupiditate deleniti exercitationem. Facilis suscipit corporis unde aut minima nihil, eum molestias itaque, t.netur, beatae ipsa at!</p> </div> </div> </body>

1 answers

solution1
 0 ACCPTED  2022-04-26 21:35:23

You need to close the menu on link click as well as cancel. I've created a function for that to avoid duplication. 

 const body = document.querySelector("body"); const navbar = document.querySelector(".navbar"); const menuBtn = document.querySelector(".menu-btn"); const cancelBtn = document.querySelector(".cancel-btn"); const menuLinks = document.querySelectorAll('.menu-list li a'); const closeMenu = () => { body.classList.remove("disabled"); navbar.classList.remove("show"); menuBtn.classList.remove("hide"); }; menuBtn.onclick = () => { navbar.classList.add("show"); menuBtn.classList.add("hide"); body.classList.add("disabled"); }; cancelBtn.onclick = () => { closeMenu(); }; menuLinks.forEach(link => { link.onclick = () => { closeMenu(); }; }); window.onscroll = () => { this.scrollY > 20? navbar.classList.add("sticky"): navbar.classList.remove("sticky"); };
 @import url('https://fonts.googleapis.com/css2?family=Poppins:wght@200;300;400;500;600;700&display=swap'); * { margin: 0; padding: 0; box-sizing: border-box; font-family: 'Poppins', sans-serif; } /* custom scroll bar */::-webkit-scrollbar { width: 10px; }::-webkit-scrollbar-track { background: #f1f1f1; }::-webkit-scrollbar-thumb { background: #888; }::selection { background: rgb(0, 123, 255, 0.3); }.content { max-width: 1250px; margin: auto; padding: 0 30px; }.navbar { position: fixed; width: 100%; z-index: 2; padding: 25px 0; transition: all 0.3s ease; }.navbar.sticky { background: #1b1b1b; padding: 10px 0; box-shadow: 0px 3px 5px 0px rgba(0, 0, 0, 0.1); }.navbar.content { display: flex; align-items: center; justify-content: space-between; }.navbar.logo a { color: #fff; font-size: 30px; font-weight: 600; text-decoration: none; }.navbar.menu-list { display: inline-flex; }.menu-list li { list-style: none; }.menu-list li a { color: #fff; font-size: 18px; font-weight: 500; margin-left: 25px; text-decoration: none; transition: all 0.3s ease; }.menu-list li a:hover { color: #007bff; }.banner { background: url("banner.jpg") no-repeat; height: 100vh; background-size: cover; background-position: center; background-attachment: fixed; }.about { padding: 30px 0; }.about.title { font-size: 38px; font-weight: 700; }.about p { padding-top: 20px; text-align: justify; }.icon { color: #fff; font-size: 20px; cursor: pointer; display: none; }.menu-list.cancel-btn { position: absolute; right: 30px; top: 20px; } @media (max-width: 1230px) {.content { padding: 0 60px; } } @media (max-width: 1100px) {.content { padding: 0 40px; } } @media (max-width: 900px) {.content { padding: 0 30px; } } @media (max-width: 868px) { body.disabled { overflow: hidden; }.icon { display: block; }.icon.hide { display: none; }.navbar.menu-list { position: fixed; height: 100vh; width: 100%; max-width: 400px; left: -100%; top: 0px; display: block; padding: 40px 0; text-align: center; background: #222; transition: all 0.3s ease; }.navbar.show.menu-list { left: 0%; }.navbar.menu-list li { margin-top: 45px; }.navbar.menu-list li a { font-size: 23px; margin-left: -100%; transition: 0.6s cubic-bezier(0.68, -0.55, 0.265, 1.55); }.navbar.show.menu-list li a { margin-left: 0px; } } @media (max-width: 380px) {.navbar.logo a { font-size: 27px; } }
 <head> <meta charset="UTF-8"> <meta name="viewport" content="width=device-width, initial-scale=1.0"> <title>Sticky Navigation Bar | CodingNepal</title> <link rel="stylesheet" href="style.css"> <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.3/css/all.min.css" /> </head> <body> <nav class="navbar"> <div class="content"> <div class="logo"> <a href="#">CodingNepal</a> </div> <ul class="menu-list"> <div class="icon cancel-btn"> <i class="fas fa-times"></i> </div> <li><a href="#">Home</a></li> <li><a href="#">About</a></li> <li><a href="#">Services</a></li> <li><a href="#">Features</a></li> <li><a href="#">Contact</a></li> </ul> <div class="icon menu-btn"> <i class="fas fa-bars"></i> </div> </div> </nav> <div class="banner"></div> <div class="about"> <div class="content"> <div class="title">Responsive Sticky Navigation Menu Bar on Scroll using HTML CSS & JavaScript</div> <p>Lorem ipsum dolor sit amet, consectetur adipisicing elit. Quo impedit atque consequatur, Iusto distinctio temporibus repellendus labore odit adipisci harum ipsa beatae natus, eum eius, hic aperiam odio, Quasi molestias magnam illo voluptatem iusto ipsam blanditiis. tempore cumque reiciendis quaerat vero t.netur, sequi dolores libero voluptas vitae voluptate placeat dolorum modi ipsa nisi repellat facilis aliquam asperiores, Aut nam repellat harum quas saepe dolorum voluptates ratione. itaque consectetur explicabo a facilis rem mollitia maxime repudiandae fuga reprehenderit, odio cum incidunt labore molestiae quis non perferendis ipsam, Illum. in. deserunt, Ipsa.</p> <p>Lorem ipsum dolor sit amet, consectetur adipisicing elit, Impedit hic excepturi nobis id, eos dolor libero, nam assumenda, at culpa quos perspiciatis ratione ea modi. Natus sapiente a, explicabo sit quisquam eligendi esse provident eos enim doloremque blanditiis aut placeat veniam, libero nostrum quae. Ipsam, iste reprehenderit minima accusantium illo dolorem recusandae. ipsa autem quidem reiciendis a mollitia sit t.netur,</p> <p>Lorem ipsum dolor sit amet, consectetur adipisicing elit? Sint doloremque perspiciatis voluptate ducimus reiciendis rem expedita voluptatibus dicta harum, quo, aspernatur maiores possimus officia quod, Aliquid molestiae illo sequi, tempora perferendis at incidunt nam porro voluptatibus, iste aperiam blanditiis adipisci ducimus repellendus distinctio nostrum ipsum, Voluptas facilis cum, atque tempora magnam beatae sequi. Doloribus expedita, cupiditate quo quod nemo aliquam, mollitia cum ea nam ullam soluta temporibus. Repudiandae incidunt consequatur distinctio deleniti obcaecati sit facilis unde, quisquam veniam ad doloribus.</p> <p>Lorem ipsum dolor sit amet, consectetur adipisicing elit. Amet veniam error deleniti cum beatae non assumenda illum est dolores, possimus suscipit quibusdam eveniet id fuga dolore unde modi, sapiente voluptas. Mollitia veritatis explicabo cumque enim quia voluptates provident totam perferendis excepturi animi assumenda optio minus laudantium eveniet possimus amet blanditiis dolore in fuga atque, earum officia tempora quam similique est,</p> <p>Lorem ipsum dolor sit amet, consectetur adipisicing elit. Itaque ad sunt distinctio quidem incidunt cupiditate sequi deleniti, corrupti officia nam veritatis facilis veniam dolorum enim nisi ipsum dolor rem, Doloribus, eaque odit voluptatem iste laboriosam provident facere quo. Cum repellat pariatur, error ratione repellendus nisi quam culpa tempora facere in atque nesciunt, magni est aliquid unde soluta optio! Dolore pariatur, quaerat quo in cupiditate deleniti exercitationem. Facilis suscipit corporis unde aut minima nihil, eum molestias itaque, t.netur, beatae ipsa at!</p> </div> </div> </body>

暂无
暂无

The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.

Related Question Make the Nav Menu close after clicking a link in <li> (Only on mobile)? Close menu after clicking menu link Close menu after clicking the menu link Close responsive top-nav bar menu after clicking a link in a single page. Foundation 6 Close burger menu after clicking on some link Close DropDown Menu after clicking a link (Bootstrap) Close toggle menu after clicking outside of it and on a link navigation bar drawer menu doesn't close after clicking menu item menu don`t collapse after clicking link Nav menu will not close when clicking the button
Related Tags
 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM