Solidity two mint functions or one?

Question

I have an ERC721 contract that has a whitelistEnabled property which, if enabled, requires the user to pass a merkleproof to the minting function. Currently, I have two functions: mint() {...} and mintWhitelist(merkleproof) {...} . Both functions have the same logic and custom implementation. The only difference is that the latter checks the merkleproof and the former doesn't.

Since the bulk of the two functions is the same, I was wondering if 'duplicating' the functions like this is the right, most gas efficient approach.

Would it be better to merge them into one? I think this might be the case, but I don't think there is a way to pass the merkleproof optionally (since there are no optional function parameters in Solidity).

Any help is appreciated!

Answer 1

You can add a boolean argument in the mint function for checks that need to merkelProof or not, if that was true you should check merhleProof and that logic is like WhiteList else you should ignore the merkelProof argument and that can be null or else. but actually, this code is so dirty and increases the gas fee for anyone use mint (not WhitListMint) and I think your code is good.