how to optimize this piece of JS code?

Question

Sorry JS newbie here:

    if (message.notify_one_day_out){
        $("#data\\[User\\]\\[notify_one_day_out\\]").val("1");
    }
    else{
        $("#data\\[User\\]\\[notify_one_day_out\\]").val("0");
    }  

The above code feels sloppy. How can I condense it? I know this is development fundamentals but can I do something like:

$("#data\\[User\\]\\[notify_one_day_out\\]").val(message.notify_one_day_out);

Answer 1

//this is actually a function call "$()" better reference it to avoid overhead
var el = $("#data\\[User\\]\\[notify_one_day_out\\]");

el.val( message.notify_one_day_out ? '1' : '0');

i suggest you turn those [] into dashes or underscores. that way it won't be that messy.

Answer 2

$("#data\\[User\\]\\[notify_one_day_out\\]").val(
               message.notify_one_day_out ? "1" : "0");

Answer 3

You can use ternary operator (also called conditional operator ):

$("#data\\[User\\]\\[notify_one_day_out\\]").val(
         message.notify_one_day_out ? '1' : '0' );

Here is prototype of ternary operator:

(expression) ? this if true : this if false;

Essentially it is shorthand of if-else statements.

---

You can read more about it here:

• https://developer.mozilla.org/en/JavaScript/Reference/Operators/Conditional_Operator

Answer 4

您可以使用三元运算符 。

$("#data\\[User\\]\\[notify_one_day_out\\]").val(message.notify_one_day_out ? "1" : "0");