$(this).attr(“href”) not working

Question

For some reason, this line of code is returning undefined for $(this).attr("href")

$("a").attr("href", "javascript:page('" + $(this).attr("href") + "')");

How can I get that value?

Answer 1

$("a").click(function(e){
    e.preventDefault();
    page(this.href);
});

Answer 2

Try:

$("a").attr("href", function (index, oldHref) {
    return "javascript:page('" + oldHref + "')");
});

Check out the documentation for attr for information about the overload that takes a function reference.

Although as @Pointy points, out, you should consider writing an event handler instead of using javascript: inside your markup.

Answer 3

This is an alternative approach that doesn't require Javascript on your href attribute

$('a').click( function(e) {
    e.preventDefault();
    page(this.href);
} )

Answer 4

You don't need inline javascript, why not do like below:

$("a").click(function(){
    page(this.href);
    return false;
});

Answer 5

If you want to do that (update all href attribute of the links on the page) you could do

$("a").each(function() {
   $(this).attr("href", "javascript:page('" + $(this).attr("href") + "')");
});