Put D3 code into a function and call

Question

Is it possible to put D3 code into a function and then call the function?

For example, I am interested in using this histogram code http://bl.ocks.org/3048450

If I put code in a function and call like



function hist(bin, data) {
    //the D3 histogram plotting code
    // Generate an Irwin–Hall distribution of 10 random variables.
    var values = d3.range(1000).map(d3.random.irwinHall(10));

    // A formatter for counts.
    var formatCount = d3.format(",.0f");

    var margin = {top: 10, right: 30, bottom: 30, left: 30},
    width = 960 - margin.left - margin.right,
    height = 500 - margin.top - margin.bottom;

    var x = d3.scale.linear()
    .domain([0, 1])
    .range([0, width]);

    // Generate a histogram using twenty uniformly-spaced bins.
    var data = d3.layout.histogram()
    .bins(x.ticks(20))
    (values);

    var y = d3.scale.linear()
    .domain([0, d3.max(data, function(d) { return d.y; })])
    .range([height, 0]);

    var xAxis = d3.svg.axis()
    .scale(x)
    .orient("bottom");

    var svg = d3.select("body").append("svg")
    .attr("width", width + margin.left + margin.right)
    .attr("height", height + margin.top + margin.bottom)
    .append("g")
    .attr("transform", "translate(" + margin.left + "," + margin.top + ")");

    var bar = svg.selectAll(".bar")
    .data(data)
    .enter().append("g")
    .attr("class", "bar")
    .attr("transform", function(d) { return "translate(" + x(d.x) + "," + y(d.y) + ")"; });

     bar.append("rect")
    .attr("x", 1)
    .attr("width", x(data[0].dx) - 1)
    .attr("height", function(d) { return height - y(d.y); });

     bar.append("text")
    .attr("dy", ".75em")
    .attr("y", 6)
    .attr("x", x(data[0].dx) / 2)
    .attr("text-anchor", "middle")
    .text(function(d) { return formatCount(d.y); });

     svg.append("g")
    .attr("class", "x axis")
    .attr("transform", "translate(0," + height + ")")
    .call(xAxis);

}

hist(...); //call the function

it doesn't plot. Why is that?

Answer 1

I found the cause of the bug. I misspell "function" as "function"

Answer 2

Where are you including and running that code? If you're including and runningit in the <head> element, then when the script executes the browser will not be aware of the <body> element. d3.select("body") will return an empty selection, and therefore there will be nothing to which to append and svg element.

Try putting the script within the <body> or use a library like jQuery (ie, $(document).ready() ) to ensure that the document has been loaded before executing your script.

Put D3 code into a function and call

Question

2 answers

solution1
1 ACCPTED 2012-11-26 02:39:58

solution2
0 2012-11-23 06:02:18

Put D3 code into a function and call

Question

2 answers

solution1 1 ACCPTED 2012-11-26 02:39:58

solution2 0 2012-11-23 06:02:18

solution1
1 ACCPTED 2012-11-26 02:39:58

solution2
0 2012-11-23 06:02:18