井字阵列错误

Question

该程序是播放器和计算机之间的一个简单的Tic Tac Toe游戏。 如果所述空间尚未被占用，则计算机仅生成一个随机空间。 另外，我在垂直轴上有x坐标，而在水平轴上有y坐标。 我这样做是因为我使用了二维数组，而这正是它们的结构方式。

运行该程序时，某些空格有问题，我无法找出原因。 当用户输入点（0,2）时，程序还将填写点（1,0），反之亦然。 点（1,2）和（2,0）也会发生这种情况。

#include<iostream>
#include<string>
#include<stdlib.h>
#include<ctime>

using namespace std;

int board[2][2];

int chooseFirstPlayer();
void userMove(int boardArray[2][2]);
void compMove(int boardArray[2][2]);
int checkIfWinner(int boardArray[2][2]);
void displayBoard(int boardArray[2][2]);

int main(){
    srand(time(NULL));
    int x,y,winner;

    for(x = 0; x <= 2; x++){ //sets the enitre board array to 0
        for(y = 0; y <= 2; y++){
            board[x][y] = 0;
        }
    }

    if (chooseFirstPlayer() == 1){ //the user gets to movve first

        do{//it will loop this until there is a winner
            displayBoard(board);
            userMove(board);
            displayBoard(board);
            winner = checkIfWinner(board);

            if (winner == 0){//after the player moves, it will see if he won. If not, then the computer willbe able to move.
                compMove(board);
                displayBoard(board);
                winner = checkIfWinner(board);
            }
        }while (winner == 0);//it will loop until a winner is found


    }   
    else{//same structure as above just slightly altered to allow the computer to move first

        do{
            compMove(board);
            displayBoard(board);
            winner = checkIfWinner(board);

            if (winner == 0){
                userMove(board);
                displayBoard(board);
                winner = checkIfWinner(board);
            }
        }while(winner == 0);
    }

    if (winner = 1){
        cout << "Congratulations, you won!";
    }
    else if (winner = 2){
        cout << "Sorry, you lost!";
    }

}

int chooseFirstPlayer(){//randomly genereate a number 1 or 2 to choose who moves first

    return rand() % 2 + 1;
}

void userMove(int boardArray[2][2]){
    int userX, userY;

    do{ 
        cout << "Enter an x coordinate: "<<endl;
        cin >> userX;

        cout << "Enter a y coordinate: "<<endl;
        cin >> userY;

        if (boardArray[userX][userY] != 0){
            cout << "That loaction is already occupied"<<endl;
        }
    }while(boardArray[userX][userX] != 0);

    boardArray[userX][userY] = 1;

}

void compMove(int boardArray[2][2]){
    int compX,compY;

    do{ 
        compX = rand() % 3;
        compY = rand() % 3;
    }while(boardArray[compX][compY] != 0);

    boardArray[compX][compY] = 2;
}

int checkIfWinner(int boardArray[2][2]){


    if(boardArray[0][0] == boardArray[0][1]  && boardArray[0][1] == boardArray[0][2]){ //across
        return boardArray[0][0];}
    else if (boardArray[1][0] == boardArray[1][1] && boardArray[1][1] == boardArray[1][2]){
        return boardArray[1][0];}
    else if (boardArray[2][0] == boardArray[2][1] && boardArray[2][1] == boardArray[2][2]){
        return boardArray[2][0];}
    else if (boardArray[0][0] == boardArray[1][0] && boardArray[1][0] == boardArray[2][0]){//down
        return boardArray[0][0];}
    else if (boardArray[0][1] == boardArray[1][1] && boardArray[1][1] == boardArray[2][1]){
        return boardArray[0][1];}
    else if (boardArray[0][2] == boardArray[1][2] && boardArray[1][2] == boardArray[2][2]){
        return boardArray[0][2];}
    else if (boardArray[0][0] == boardArray[1][1] && boardArray[1][1] == boardArray[2][2]){//diagonal
        return boardArray[0][0];}
    else if (boardArray[2][0] == boardArray[1][1] && boardArray[1][1] == boardArray[0][2]){
        return boardArray[2][0];}
    else{
        return 0;
        }

}

void displayBoard(int boardArray[2][2]){

    system("CLS");

    cout <<"    "<<"  Y1  "<<"  Y2  "<<"  Y3  "<<endl;
    cout <<" X1 "<< "__"<<boardArray[0][0]<<"__|__"<<boardArray[0][1]<<"__|__"<<boardArray[0][2]<<"__"<<endl;
    cout <<" X2 "<< "__"<<boardArray[1][0]<<"__|__"<<boardArray[1][1]<<"__|__"<<boardArray[1][2]<<"__"<<endl;
    cout <<" X3 "<< "  "<<boardArray[2][0]<<"  |  "<<boardArray[2][1]<<"  |  "<<boardArray[2][2]<<"  "<<endl;
}

我的IDE是Dev-C ++（5.4.2）

Answer 1

您的数组是2x2，您可以执行以下操作：

for(x = 0; x <= 2; x++){ //sets the enitre board array to 0
        for(y = 0; y <= 2; y++){
            board[x][y] = 0;
        }
    }

而您不应该访问内存。 这意味着您将越界！

x和y最终将取等于2的值。

数组的索引从0开始直到其大小-1。

因此，您可以使用3x3的数组，或更改代码（以及直到2的checkIfWinner函数）。

---

边注：

您在这里错过了相等运算符：

if (winner = 1){
    cout << "Congratulations, you won!";
}
else if (winner = 2){
    cout << "Sorry, you lost!";
}

如果保持原样会怎样？ 赋值将发生并导致逻辑为真，因此第一个条件将始终为真（第二个条件为零，但代码不会走得那么远）。

因此，用==更改= 。