变量“变量名称”周围的堆栈已损坏C ++

Question

我有一个我的代码，应该是大学项目的mips处理器的汇编程序。
现在我的问题是在执行程序时一切顺利，直到程序退出主程序它会引发此错误：

变量binaryinstruction周围的堆栈已损坏。

退出main时会抛出错误，我无法在任何地方找到有效的解决方案。

下面是我的代码示例：

#include <iostream>
#include <fstream>
#include <string>
#include <bitset>
using namespace std;
//function to convert string to binary
bool tobool(char x)
{
    if (x == '0')
        return 0;
    else
        return 1;
}
//function to decode the register name into an address using call by refrence to modify the instruction boolean encoding array
void register_encode(string Register, bool &address2, bool &address3, bool &address4, bool &address5, bool &address6)
{
    if (Register == "$zero")
    {
        address2 = 0;   address3 = 0;   address4 = 0;   address5 = 0;   address6 = 0;
    }
    else if (Register == "$t3")
    {
        address2 = 0; address3 = 1; address4 = 0; address5 = 1; address6 = 1;
    }
    else if (Register == "$s2")
    {
        address2 = 1; address3 = 0; address4 = 0; address5 = 1; address6 = 0;
    }
}

//function to count the number of occurence of commas (,) inside the string
int count_commas(string s) {
    int count = 0;

    for (int i = 0; i < s.size(); i++)
        if (s[i] == ',') count++;
    return count;
}

void main()
{
    int numberofinstruction = 0;
    string testingstring;
    string line[64];
    ifstream myfile;
    myfile.open("test.txt");
    // taking input from file into an array "line" which holds every single line inside the array in a single element inside the array
    while (getline(myfile, testingstring))
    {

        line[numberofinstruction] = testingstring;
        numberofinstruction++;
    }
    myfile.close();
    //transform to binary
    bool binaryinstruction[31];
    string firstterm, secondterm, thirdterm, fourthterm;
    for (int counter = 0; counter<numberofinstruction; counter++)
    {
        switch (count_commas(line[counter])) {
        case 1:
            firstterm = line[counter].substr(0, line[counter].find(" "));
            secondterm = line[counter].substr(line[counter].find(" ") + 1, line[counter].find(",") - line[counter].find(" ") - 1);
            thirdterm = line[counter].substr(line[counter].find(",") + 1, line[counter].size() - line[counter].find(","));
            if (firstterm == "lw")
            {   //LW encoding
                binaryinstruction[0] = 1;
                binaryinstruction[1] = 0;
                binaryinstruction[2] = 0;
                binaryinstruction[3] = 0;
                binaryinstruction[4] = 1;
                binaryinstruction[5] = 1;
                register_encode(secondterm, binaryinstruction[11], binaryinstruction[12], binaryinstruction[13], binaryinstruction[14], binaryinstruction[15]);
                string offset = thirdterm.substr(0, thirdterm.find('('));
                offset = bitset<16>(stoi(offset)).to_string();
                for (int x = 0; x <= 15; x++)
                {
                    binaryinstruction[16 + x] = tobool(offset[x]);
                }
                string lwregister = thirdterm.substr(thirdterm.find('$'), thirdterm.size() - thirdterm.find('(') - 2);
                register_encode(lwregister, binaryinstruction[6], binaryinstruction[7], binaryinstruction[8], binaryinstruction[9], binaryinstruction[10]);
            }
            else
            {   //SW encoding
                binaryinstruction[0] = 1;
                binaryinstruction[1] = 0;
                binaryinstruction[2] = 1;
                binaryinstruction[3] = 0;
                binaryinstruction[4] = 1;
                binaryinstruction[5] = 1;
                //begin
                register_encode(secondterm, binaryinstruction[11], binaryinstruction[12], binaryinstruction[13], binaryinstruction[14], binaryinstruction[15]);
                string offset = thirdterm.substr(0, thirdterm.find('('));
                offset = bitset<16>(stoi(offset)).to_string();
                for (int x = 0; x <= 15; x++)
                {
                    binaryinstruction[16 + x] = tobool(offset[x]);
                }
                string lwregister = thirdterm.substr(thirdterm.find('$'), thirdterm.size() - thirdterm.find('(') - 2);
                register_encode(lwregister, binaryinstruction[6], binaryinstruction[7], binaryinstruction[8], binaryinstruction[9], binaryinstruction[10]);
                //end

            }
            break;

        }
    }
    //testing
    ofstream myfile2("testout.txt");

    for (int f = 0; f <= 31; f = f + 8)
    {
        myfile2 << binaryinstruction[f] << binaryinstruction[f + 1] << binaryinstruction[f + 2] << binaryinstruction[f + 3] << binaryinstruction[f + 4] << binaryinstruction[f + 5] << binaryinstruction[f + 6] << binaryinstruction[f + 7] << endl;
    }
    //end testing
}

在测试文件中，我有1行，即lw $t3,4($s2) ，要在testout文件中写入的输出符合预期：

10001110
01001011
00000000
00000100

Answer 1

我的问题是访问不存在的数组的索引我忘了在C ++中识别数组时您键入数组内的元素数而不是数组的最后一个索引。 令我困惑的是抛出错误的地方，当使用断点进行调试时，它会在退出void main()时抛出异常，而不是在访问未识别的数组元素时抛出异常。

Answer 2

与大多数其他高级语言不同，C ++不一定执行数组索引检查。 因此，索引错误会导致未定义的行为 。 在你的情况下，这会在退出时产生一条消息，但通常这种类型的错误完全没有报告。

虽然有解决方案，特别是使用更现代的数组类型容器，如std::array和std::vector 。 出于速度优化的原因，这些也不会在默认操作模式下执行索引检查，但是有一些方法可以启用它。 在这里看到我的答案。

Answer 3

这不是答案，但不能适用于评论

开始了...

bool tobool(char x)
{
    if (x == '0')
        return 0;
    else
        return 1;

应该

bool tobool(char x)
{
   return x == '0'? false : true;
}

然后

 void register_encode(string Register, bool &address2, bool &address3, bool &address4, bool &address5, bool &address6)

{

应该

void register_encode(const std::string& Register, bool &address2, bool &address3, bool &address4, bool &address5, bool &address6)

{

同上

count_commas

我确信std::string中有一个方法可以做到这一点

也

void main()

应该

 int main()