变量“名称”周围的堆栈已损坏C ++

Question

我正在尝试使用CStrings在C ++中执行其他任务，例如从提供的名称中删除所有元音。 但是，我似乎无法弄清楚为什么会出现此错误：

变量“名称”周围的堆栈已损坏。

为什么会这样呢？

这是代码：

#include <iostream>
#include <iomanip>
#include <cstring>
#include <string>

using namespace std;

    void cStringDemo();
    void stringDemo();
    void removeCVowels(char myGuess[50]);

int main() {
    cStringDemo();
    cin.get();
    cin.ignore();
}


void cStringDemo() {
    char name[] = "Seth Smith";
    char guess[50];
    cout << "Guess my name! [First and Last, EX: Bobby Hall.]" << endl;
    cin.get(guess, 20);
    if (strcmp(name, guess) == 0) {
        cout << "Correct!" << endl;
    }
    else {
    cout << "Incorrect!" << endl;
    }
    cout << "You guessed " << guess << "." << endl;

    removeCVowels(guess);

}

void removeCVowels(char myGuess[50]) {
    char nameNoVowel[50];
    strcpy_s(myGuess, 100, nameNoVowel);
    for (int x = 0; x < 50; x++) {
        if (nameNoVowel[x] == 'a' || nameNoVowel[x] == 'e' || nameNoVowel[x] == 'i' || nameNoVowel[x] == 'o' || nameNoVowel[x] == 'u' || nameNoVowel[x] == 'A' || nameNoVowel[x] == 'E' ||
        nameNoVowel[x] == 'I' || nameNoVowel[x] == 'O' || nameNoVowel[x] == 'U')
    {
        nameNoVowel[x] = ' ';
    }
    }
}

Answer 1

这是未定义的行为：

void removeCVowels(char myGuess[50]) {
    char nameNoVowel[50];
    strcpy_s(myGuess, 100, nameNoVowel);

您正在从未初始化的nameNoVowel复制到myGuess 。 您应该交换strcpy_s的参数。 同样，即使您交换了strcpy_s的两个参数，由于nameNoVowel仅为50个字符，所以限制也太大了。 尝试：

void removeCVowels(char myGuess[50]) {
    char nameNoVowel[50];
    strcpy_s(nameNoVowel, sizeof(nameNoVowel)-1, myGuess);

Answer 2

您发布的代码中存在一些问题。 以下是修正了代码的代码，并在注释中说明了错误：

void cStringDemo() {
    char name[] = "Seth Smith";
    char guess[50] = {0};  //in here initialize the table with zeros
    cout << "Guess my name! [First and Last, EX: Bobby Hall.]" << endl;
    cin.get(guess, 20); // I am not sure why you want 20 characters and have array of size 50
    if (strcmp(name, guess) == 0) {
        cout << "Correct!" << endl;
    }
    else {
    cout << "Incorrect!" << endl;
    }
    cout << "You guessed " << guess << "." << endl;

    removeCVowels(guess);

}

void removeCVowels(char myGuess[50]) {
    char nameNoVowel[50] = {0}; //it is always good to initialize variables
    strcpy_s(myGuess, 50, nameNoVowel); //here lies the problem you tried to copy 100
                                        // characters from array size of 50 this leads 
                                        //to undefined behaviour of your program and stack corruption
    for (int x = 0; x < 50; x++) {
        if (nameNoVowel[x] == 'a' || nameNoVowel[x] == 'e' || nameNoVowel[x] == 'i' || nameNoVowel[x] == 'o' || nameNoVowel[x] == 'u' || nameNoVowel[x] == 'A' || nameNoVowel[x] == 'E' ||
        nameNoVowel[x] == 'I' || nameNoVowel[x] == 'O' || nameNoVowel[x] == 'U')
    {
        nameNoVowel[x] = ' ';
    }
    }
}