[英]F# MailboxProcessor - multiple waiting reader continuations for mailbox
我正在玩写一些非常简单的异步测试框架。 但我认为我正在遇到某种限制或错误。 抱歉,我无法在较小的代码库上重现这一点。
这是我提出的基本框架:
module TestRunner
open System
type TestOptions = {
Writer : ConsoleColor -> string -> unit}
type TestResults = {
Time : TimeSpan
Failure : exn option
}
type Test = {
Name : string
Finished : IEvent<TestResults>
SetFinished : TestResults -> unit
TestFunc : TestOptions -> Async<TestResults> }
let createTest name f =
let ev = new Event<TestResults>()
{
Name = name
Finished = ev.Publish
SetFinished = (fun res -> ev.Trigger res)
TestFunc =
(fun options -> async {
let watch = System.Diagnostics.Stopwatch.StartNew()
try
do! f options
watch.Stop()
return { Failure = None; Time = watch.Elapsed }
with exn ->
watch.Stop()
return { Failure = Some exn; Time = watch.Elapsed }
})}
let simpleTest name f =
createTest name (fun options -> f options.Writer)
/// Create a new Test and change the result
let mapResult mapping test =
{ test with
TestFunc =
(fun options -> async {
let! result = test.TestFunc options
return mapping result})}
let writeConsole color f =
let old = System.Console.ForegroundColor
try
System.Console.ForegroundColor <- color
f()
finally
System.Console.ForegroundColor <- old
let printColor color (text:String) =
writeConsole color (fun _ -> Console.WriteLine(text))
type WriterMessage =
| NormalWrite of ConsoleColor * String
| StartTask of AsyncReplyChannel<int> * String
| WriteMessage of int * ConsoleColor * String
| EndTask of int
/// will handle printing jobs for two reasons
/// 1. Nice output grouped by tests (StartTask,WriteMessage,EndTask)
/// 2. Print Summary after all tests finished (NormalWrite)
let writer = MailboxProcessor.Start (fun inbox ->
let currentTask = ref 0
let newHandle (returnHandle:AsyncReplyChannel<int>) =
let handle = System.Threading.Interlocked.Increment currentTask
returnHandle.Reply handle
handle
// the tasks describe which tasks are currently waiting to be processed
let rec loop tasks = async {
let! newTasks =
match tasks with
/// We process the Task with the number t and the name name
| (t, name) :: next ->
inbox.Scan
(fun msg ->
match msg with
| EndTask (endTask) ->
// if the message is from the current task finish it
if t = endTask then
Some (async { return next })
else None
| WriteMessage(writeTask, color, message) ->
if writeTask = t then
Some (async {
printColor color (sprintf "Task %s: %s" name message)
return tasks
})
else None
| StartTask (returnHandle, name) ->
// Start any tasks instantly and add them to the list (because otherwise they would just wait for the resonse)
Some (async {
let handle = newHandle returnHandle
return (List.append tasks [handle, name]) })
| _ -> None)
// No Current Tasks so just start ones or process the NormalWrite messages
| [] ->
inbox.Scan
(fun msg ->
match msg with
| StartTask (returnHandle, name) ->
Some (async {
let handle = newHandle returnHandle
return [handle, name] })
| NormalWrite(color, message) ->
Some (async {
printColor color message
return []
})
| _ -> None)
return! loop newTasks
}
loop [])
/// Write a normal message via writer
let writerWrite color (text:String) =
writer.Post(NormalWrite(color, text))
/// A wrapper around the communication (to not miss EndTask for a StartTask)
let createTestWriter name f = async {
let! handle = writer.PostAndAsyncReply(fun reply -> StartTask(reply, name))
try
let writer color s =
writer.Post(WriteMessage(handle,color,s))
return! f(writer)
finally
writer.Post (EndTask(handle))
}
/// Run the given test and print the results
let testRun t = async {
let! results = createTestWriter t.Name (fun writer -> async {
writer ConsoleColor.Green (sprintf "started")
let! results = t.TestFunc { Writer = writer }
match results.Failure with
| Some exn ->
writer ConsoleColor.Red (sprintf "failed with %O" exn)
| None ->
writer ConsoleColor.Green (sprintf "succeeded!")
return results})
t.SetFinished results
}
/// Start the given task with the given amount of workers
let startParallelMailbox workerNum f =
MailboxProcessor.Start(fun inbox ->
let workers = Array.init workerNum (fun _ -> MailboxProcessor.Start f)
let rec loop currentNum = async {
let! msg = inbox.Receive()
workers.[currentNum].Post msg
return! loop ((currentNum + 1) % workerNum)
}
loop 0 )
/// Runs all posted Tasks
let testRunner =
startParallelMailbox 10 (fun inbox ->
let rec loop () = async {
let! test = inbox.Receive()
do! testRun test
return! loop()
}
loop ())
/// Start the given tests and print a sumary at the end
let startTests tests = async {
let! results =
tests
|> Seq.map (fun t ->
let waiter = t.Finished |> Async.AwaitEvent
testRunner.Post t
waiter
)
|> Async.Parallel
let testTime =
results
|> Seq.map (fun res -> res.Time)
|> Seq.fold (fun state item -> state + item) TimeSpan.Zero
let failed =
results
|> Seq.map (fun res -> res.Failure)
|> Seq.filter (fun o -> o.IsSome)
|> Seq.length
let testCount = results.Length
if failed > 0 then
writerWrite ConsoleColor.DarkRed (sprintf "--- %d of %d TESTS FAILED (%A) ---" failed testCount testTime)
else
writerWrite ConsoleColor.DarkGray (sprintf "--- %d TESTS FINISHED SUCCESFULLY (%A) ---" testCount testTime)
}
现在只有在我使用一组特定的测试时才会触发异常,这些测试会在Web上进行一些爬行(有些失败,有些失败则没有问题):
#r @"Yaaf.GameMediaManager.Primitives.dll";; // See below
open TestRunner
let testLink link =
Yaaf.GameMediaManager.EslGrabber.getMatchMembers link
|> Async.Ignore
let tests = [
// Some working links (links that should work)
yield!
[ //"TestMatch", "http://www.esl.eu/eu/wire/anti-cheat/css/anticheat_test/match/26077222/"
"MatchwithCheater", "http://www.esl.eu/de/csgo/ui/versus/match/3035028"
"DeletedAccount", "http://www.esl.eu/de/css/ui/versus/match/2852106"
"CS1.6", "http://www.esl.eu/de/cs/ui/versus/match/2997440"
"2on2Versus", "http://www.esl.eu/de/css/ui/versus/match/3012767"
"SC2cup1on1", "http://www.esl.eu/eu/sc2/go4sc2/cup230/match/26964055/"
"CSGO2on2Cup", "http://www.esl.eu/de/csgo/cups/2on2/season_08/match/26854846/"
"CSSAwpCup", "http://www.esl.eu/eu/css/cups/2on2/awp_cup_11/match/26811005/"
] |> Seq.map (fun (name, workingLink) -> simpleTest (sprintf "TestEslMatches_%s" name) (fun o -> testLink workingLink))
]
startTests tests |> Async.Start;; // this will produce the Exception now and then
https://github.com/matthid/Yaaf.GameMediaManager/blob/core/src/Yaaf.GameMediaManager.Primitives/EslGrabber.fs是代码,您可以下载https://github.com/downloads/matthid/Yaaf。 GameMediaManager / GameMediaManager。%200.9.3.1.wireplugin (这基本上是一个重命名的zip存档)并解压缩得到Yaaf.GameMediaManager.Primitives.dll二进制文件(你可以把它粘贴到FSI而不是你想要的下载但是你有引用HtmlAgilityPack)
我可以使用Microsoft(R)F#2.0 Interactive,Build 4.0.40219.1重现这一点。 问题是异常不会一直触发(但经常)并且堆栈跟踪不会告诉我什么
System.Exception: multiple waiting reader continuations for mailbox
bei <StartupCode$FSharp-Core>.$Control.-ctor@1860-3.Invoke(AsyncParams`1 _arg11)
bei <StartupCode$FSharp-Core>.$Control.loop@413-40(Trampoline this, FSharpFunc`2 action)
bei Microsoft.FSharp.Control.Trampoline.ExecuteAction(FSharpFunc`2 firstAction)
bei Microsoft.FSharp.Control.TrampolineHolder.Protect(FSharpFunc`2 firstAction)
bei <StartupCode$FSharp-Core>.$Control.finishTask@1280[T](AsyncParams`1 _arg3, AsyncParamsAux aux, FSharpRef`1 firstExn, T[] results, TrampolineHolder trampolineHolder, Int32 remaining)
bei <StartupCode$FSharp-Core>.$Control.recordFailure@1302[T](AsyncParams`1 _arg3, AsyncParamsAux aux, FSharpRef`1 count, FSharpRef`1 firstExn, T[] results, LinkedSubSource innerCTS, TrampolineHolder trampolineHolder, FSharpChoice`2 exn)
bei <StartupCode$FSharp-Core>.$Control.Parallel@1322-3.Invoke(Exception exn)
bei Microsoft.FSharp.Control.AsyncBuilderImpl.protectedPrimitive@690.Invoke(AsyncParams`1 args)
bei <StartupCode$FSharp-Core>.$Control.loop@413-40(Trampoline this, FSharpFunc`2 action)
bei Microsoft.FSharp.Control.Trampoline.ExecuteAction(FSharpFunc`2 firstAction)
bei Microsoft.FSharp.Control.TrampolineHolder.Protect(FSharpFunc`2 firstAction)
bei <StartupCode$FSharp-Core>.$Control.-ctor@473-1.Invoke(Object state)
bei System.Threading.QueueUserWorkItemCallback.WaitCallback_Context(Object state)
bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean ignoreSyncCtx)
bei System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
bei System.Threading.ThreadPoolWorkQueue.Dispatch()
bei System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()
因为这将在我无法控制的工作线程上触发,这将使应用程序崩溃(不是FSI,但此处也会显示异常)。
我找到了http://cs.hubfs.net/topic/Some/2/59152和http://cs.hubfs.net/topic/None/59146,但我不使用StartChild,我不认为我是某种程度上同时调用从多个线程接收?
我的代码有什么问题,或者这确实是一个错误? 如果可能,我该如何解决这个问题?
我注意到在FSI中,当默认忽略Exception时,所有测试都将按预期运行。 我怎么能这样做?
编辑:我注意到我修复了失败的单元测试后它会正常工作。 但是,我不能用较小的代码库重现这一点。 例如,我自己的失败测试。
谢谢,matthid
我的感觉是限制将在MailboxProcessor本身而不是异步。
说实话,我会谨慎使用扫描功能。 我写了一篇关于使用它们的危险的博客文章 。
是否可以使用标准接收机制而不是使用扫描功能来处理任务?
作为一个注释,在异步内部有一个trampoline被使用,以便相同的线程被重用一段时间,以避免不必要的线程池使用,(我认为这设置为300)所以在调试时你可能会看到这种行为。
我会稍微区别地解决这个问题,将单独的组件分解为管道阶段而不是嵌套的异步块。 我将创建一个supervisor组件和路由组件。
主管将负责初始测试并将消息发布到路由组件,该组件将请求循环到其他代理。 任务完成后,他们可以回复给主管。
我意识到这对当前代码中的问题没有任何帮助,但我认为无论如何都要分解问题以调试系统的异步部分。
我相信在Scan
/ TryScan
/ Receive
的2.0实现中有一个错误可能会导致错误
multiple waiting reader continuations for mailbox
例外; 我认为现在已经在3.0实现中修复了这个bug。 我没有仔细查看您的代码,以确保您在实现中一次只尝试接收一条消息,因此这也可能是您的代码中的错误。 如果你可以尝试对抗F#3.0,那么很高兴知道这是否会消失。
一些注意事项,以防有人发现我的经验有用(调试多个进程需要很长时间才能找到问题):
只有50个代理/邮箱,执行和吞吐量开始变得堵塞。 有时轻负载它会对第一轮消息起作用,但是对调用日志库的任何重要事件都会触发更长的延迟。
使用VS IDE中的Threads / Parallel Stacks窗口进行调试,运行时正在等待FSharpAsync.RunSynchronously - > CancellationTokenOps.RunSynchronously调用Trampoline.ExecuteAction的结果
我怀疑底层的ThreadPool是限制启动(在它第一次运行似乎运行正常之后)。 这是一个很长的延迟。 我正在使用代理在某些队列中进行小规模计算,同时允许主调度代理保持响应,因此延迟在CLR中的某处。
我发现在try-with中运行带有Timeout的MailboxProcessor Receive,停止了延迟,但是这需要包含在异步块中以阻止程序的其余部分减慢,但是延迟时间很短。 尽管有点蠢蠢欲动,但对于实现actor模型的F#MailboxProcessor非常满意。
遗憾的是,我从来没有真正能够在较小的代码库上重现这一点,现在我将使用NUnit与异步测试支持而不是我自己的实现。 我在各种项目中使用了代理(MailboxProcessor)和asyncs,从未再遇到过这种情况......
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.