XCode Cocos2d EXC_BAD_ACCESS错误

Question

我按照教程进行了一个小游戏。 游戏的工作方式如下，你控制一条特殊的鱼; 敌人的鱼类产生了周围，目标是吃其他鱼类。

我的问题是，我希望能够以任何顺序吃任何鱼。 现在我只能吃最后产生的敌人鱼。

当我尝试以错误的顺序吃鱼时，它会因EXC_BAD_ACCESS code = 1错误而崩溃。

我试了几个小时但是找不到它！

这是我的代码：

@implementation HelloWorldLayer
NSMutableArray *_targets;
bool ScheduleVerification=NO;
NSMutableArray *ArraySides;

-(id) init
{
// always call "super" init
// Apple recommends to re-assign "self" with the "super's" return value
if( (self=[super init]) ) {
    CGSize winSize = [[CCDirector sharedDirector] winSize];
   player = [CCSprite spriteWithFile:@"Fish1.png"
                                           rect:CGRectMake(0, 0, 15, 15)];
    NSLog(@"//Init//");
    _targets=[[NSMutableArray alloc] init];
  [self schedule:@selector(update:)];
    [self schedule:@selector(tracks:) interval:1];
    self.isTouchEnabled = YES;
    CCSprite *background = [CCSprite spriteWithFile:@"UnderwaterBackground.png"];
    background.position = ccp(winSize.width/2, winSize.height/2);
    CGSize BBox=[background boundingBox].size;
    [background setScaleX:(winSize.width)/BBox.width];
[background setScaleY:(winSize.height)/BBox.height];
    player.position = ccp(winSize.width/2, winSize.height/2);
    [self addChild:background];
    [self addChild:player];
}
return self;
}
-(void)ccTouchesBegan:(NSSet *)touches withEvent:(UIEvent *)event{
NSLog(@"CB1");
UITouch *touch=[touches anyObject];
CGPoint location=[touch locationInView:[touch view]];
location=[[CCDirector sharedDirector]convertToGL:location];
if (location.x<player.position.x){[player setFlipX:YES];}
if (location.x>=player.position.x){[player setFlipX:NO];}

[player runAction:[CCSequence actions:
                [CCMoveTo actionWithDuration:1.5 position:location],
                nil]];   
}
-(void)spriteMoveFinished:(id)sender {
   NSLog(@"CLEANUP");
CCSprite *sprite = (CCSprite *)sender;


    [_targets removeObject:sprite];
    [self removeChild:sprite cleanup:YES];

}
-(void)addTarget {
 NSLog(@"//addTarget//");
CCSprite *target = [CCSprite spriteWithFile:@"BadFish1.png"
                                       rect:CGRectMake(0, 0, 15, 15)];

// Determine where to spawn the target along the Y axis
CGSize winSize = [[CCDirector sharedDirector] winSize];
int minY = target.contentSize.height/2;
int maxY = winSize.height - target.contentSize.height/2;
int rangeY = maxY - minY;
int actualY = (arc4random() % rangeY) + minY;
target.tag = 1;
[_targets addObject:target];

int ranSides=arc4random()%2;

int actualSide=winSize.width;
if (ranSides==0){actualSide=0;}

target.position = ccp(actualSide, actualY);
[self addChild:target];
NSLog(@"TARGET %@",target);


// Create the actions
id actionMove = [CCMoveTo actionWithDuration:15
                                    position:ccp(winSize.width, actualY)];
if (ranSides==1){actionMove = [CCMoveTo actionWithDuration:15
                                                  position:ccp(0, actualY)];
    [target setFlipX:YES];

}

id actionMoveDone = [CCCallFuncN actionWithTarget:self
                                         selector:@selector(spriteMoveFinished:)];
[target runAction:[CCSequence actions:actionMove, actionMoveDone, nil]];

}
-(void)gameLogic:(ccTime)dt {
 NSLog(@"CB2");
[self addTarget];
ScheduleVerification=NO;

}

-(void)tracks:(ccTime)dt {
NSLog(@"CB3");
int FishInterval=arc4random()%7+3;
// [self cleanup];

if (ScheduleVerification==NO){[self schedule:@selector(gameLogic:) interval:1 repeat:0 delay: FishInterval];}
ScheduleVerification=YES;
}

- (void)update:(ccTime)dt {

//  NSMutableArray *playerToDelete = [[NSMutableArray alloc] init];
//NSMutableArray *targetsToDelete = [[NSMutableArray alloc] init];
    CGRect playerRect = CGRectMake(
                                       player.position.x - (player.contentSize.width/2),
                                       player.position.y - (player.contentSize.height/2),
                                       player.contentSize.width, 
                                       player.contentSize.height);

              for (CCSprite *target in _targets) {
        CGRect targetRect = CGRectMake(
                                       target.position.x - (target.contentSize.width/2),
                                       target.position.y - (target.contentSize.height/2),
                                       target.contentSize.width,
                                       target.contentSize.height);

        if (CGRectIntersectsRect(targetRect, playerRect)) {
        [_targets removeObject:target];[self removeChild:target cleanup:YES];
 //   [targetsToDelete addObject:target];
        }
        }
}
- (void) dealloc
{
NSLog(@"DEALLOC");
[_targets release];
_targets = nil;
[super dealloc];
}

并在.h文件中：

@interface HelloWorldLayer : CCLayerColor
{
CCSprite *player;

}

我该怎么办才能以任何顺序吃鱼？ 我究竟做错了什么？

Answer 1

您正在犯下令人发指的罪行，在迭代时从数组中删除元素。

将代码格式化得更好，并查看它：

for (CCSprite *target in _targets) {
    CGRect targetRect = CGRectMake(
        target.position.x - (target.contentSize.width/2),
        target.position.y - (target.contentSize.height/2),
        target.contentSize.width,
        target.contentSize.height);
    if (CGRectIntersectsRect(targetRect, playerRect)) {
        [targetsToDelete addObject:target];
    }
    if (targetsToDelete.count > 0) {
        NSLog(@"Target Deleted");
        NSLog(@"targets %@",_targets);
        NSLog(@"target %@",target);
        [_targets removeObject:target];
        [self removeChild:target cleanup:YES];
    }
}

你有目标targetsToDelete这一事实向我建议（无论是通过预见还是你所遵循的教程），它都是为了正确地做到这一点。 但是有些事情出了问题。

考虑一下：

for (CCSprite *target in _targets) {
    CGRect targetRect = CGRectMake(
        target.position.x - (target.contentSize.width/2),
        target.position.y - (target.contentSize.height/2),
        target.contentSize.width,
        target.contentSize.height);
    if (CGRectIntersectsRect(targetRect, playerRect)) {
        [targetsToDelete addObject:target];
    }
}

for(CCSprite* target in targetsToDelete) {
    NSLog(@"Target Deleted");
    NSLog(@"targets %@",_targets);
    NSLog(@"target %@",target);
    [_targets removeObject:target];
    [self removeChild:target cleanup:YES];
}

[targetsToDelete removeAllObjects];

你现在运行_targets ，将每一个添加到你已经吃掉到targetsToDelete ，并在完成迭代_targets ，然后单独删除它们。

Answer 2

你检查命中的循环看起来非常奇怪。 为什么要向targetsToDelete添加项目？ 我认为targetsToDelete的最终版本可能就是问题所在。 像这样简化循环，看看会发生什么（不是在Mac的前面）： -

- (void)update:(ccTime)dt {
//  NSMutableArray *playerToDelete = [[NSMutableArray alloc] init];
NSMutableArray *targetsToDelete = [[NSMutableArray alloc] init];
    CGRect playerRect = CGRectMake(
                                       player.position.x - (player.contentSize.width/2),
                                       player.position.y - (player.contentSize.height/2),
                                       player.contentSize.width, 
                                       player.contentSize.height);

              for (CCSprite *target in _targets) {
        CGRect targetRect = CGRectMake(
                                       target.position.x - (target.contentSize.width/2),
                                       target.position.y - (target.contentSize.height/2),
                                       target.contentSize.width,
                                       target.contentSize.height);

        if (CGRectIntersectsRect(targetRect, playerRect)) {



                 //    [targetsToDelete addObject:target];
                    NSLog(@"Target Deleted");
                    NSLog(@"targets %@",_targets);
                    NSLog(@"target %@",target);

                   [_targets removeObject:target];[self removeChild:target cleanup:YES];

                }

}