[英]IndexError: list index out of range in a matrix
我一直在嘗試創建一個程序生成的地牢,如本文所示。 但這對我來說有點難以理解這種算法的工作原理。 所以相反,我一直在使用它作為至少了解房間布置的指南。
文章中使用的程序是用Java編寫的,所以我根據自己的“現實”做了一些改編,並嘗試在Python 3.5中模擬出同樣的結果。
我的代碼如下:
from random import randint
class Room:
"""docstring for Room"""
def __init__(self, x, y, w, h):
"""[summary]
[description]
Arguments:
x {int} -- bottom-left horizontal anchorpoint of the room
y {int} -- bottom-left vertical anchor point of the room
w {int} -- width of the room
h {int} -- height of the room
"""
self.x1 = x
self.x2 = x + w
self.y1 = y
self.y2 = y + h
self.w = w
self.h = h
self.center = ((self.x1 + self.x2)/2, (self.y1 + self.y2)/2)
def intersects(self, room):
"""[summary]
Verifies if the rooms overlap
Arguments:
room {Room} -- a room object
"""
return(self.x1 <= room.x2 and self.x2 >= room.x1 and \
self.y1 <= room.y2 and self.y2 >= room.y1)
def __str__(self):
room_info = ("Coords: (" + str(self.x1) + ", " + str(self.y1) +
") | (" + str(self.x2) + ", " + str(self.y2) + ")\n")
room_info += ("Center: " + str(self.center) + "\n")
return(room_info)
MIN_ROOM_SIZE = 10
MAX_ROOM_SIZE = 20
MAP_WIDTH = 400
MAP_HEIGHT = 200
MAX_NUMBER_ROOMS = 20
dungeon_map = [[None] * MAP_WIDTH for i in range(MAP_HEIGHT)]
# print(dungeon_map)
def crave_room(room):
"""[summary]
"saves" a room in the dungeon map by making everything inside it's limits 1
Arguments:
room {Room} -- the room to crave in the dungeon map
"""
for x in xrange(min(room.x1, room.x2), max(room.x1, room.x2) + 1):
for y in xrange(min(room.y1, room.y2), max(room.y1, room.y2) + 1):
print(x, y) # debug
dungeon_map[x][y] = 1
print("Done") # dungeon
def place_rooms():
rooms = []
for i in xrange(0, MAX_NUMBER_ROOMS):
w = MIN_ROOM_SIZE + randint(0, MAX_ROOM_SIZE - MIN_ROOM_SIZE + 1)
h = MIN_ROOM_SIZE + randint(0, MAX_ROOM_SIZE - MIN_ROOM_SIZE + 1)
x = randint(0, MAP_WIDTH - w) + 1
y = randint(0, MAP_HEIGHT - h) + 1
new_room = Room(x, y, w, h)
fail = False
for other_room in rooms:
if new_room.intersects(other_room):
fail = True
break
if not fail:
print(new_room)
crave_room(new_room) # WIP
new_center = new_room.center
# rooms.append(new_room)
if len(rooms) != 0:
prev_center = rooms[len(rooms) - 1].center
if(randint(0, 1) == 1):
h_corridor(prev_center[0], new_center[0], prev_center[1])
v_corridor(prev_center[1], new_center[1], prev_center[0])
else:
v_corridor(prev_center[1], new_center[1], prev_center[0])
h_corridor(prev_center[0], new_center[0], prev_center[1])
if not fail:
rooms.append(new_room)
for room in rooms:
print(room)
def h_corridor(x1, x2, y):
for x in xrange(min(x1, x2), max(x1, x2) + 1):
dungeon_map[x][y] = 1
def v_corridor(y1, y2, x):
for y in xrange(min(y1, y2), max(y1, y2) + 1):
dungeon_map[x][y] = 1
place_rooms()
但是每當我運行它時,都會出現以下錯誤:
Traceback (most recent call last):
File "/home/user/dungeon.py", line 114, in <module>
place_rooms()
File "/home/user/dungeon.py", line 87, in place_rooms
crave_room(new_room)
File "/home/user/dungeon.py", line 65, in crave_room
dungeon_map[x][y] = 1
IndexError: list index out of range
根據我從代碼中的理解, crave_room
函數應該可以正常工作,因為我使用的是min
和max
函數。 並且由於h_corridor
和v_corridor
函數以類似的方式工作,因此它們存在相同類型的問題。
我不確定問題是否發生,因為我使用矩陣代替原始文章中使用的畫布。 我懷疑是局部/全局變量問題,但我認為這不是問題所在。 恐怕我犯了一個非常愚蠢的錯誤而沒有看到它。
歡迎任何關於更好的數據結構使用的代碼改進技巧或建議,如果有人有關於該主題的更清晰/更簡單的文章,最好是關於 Python,我在這里看到了很多相關的帖子,但我還是有點失落。
謝謝你的幫助。 :D
您的dungeon_map
聲明不正確:
dungeon_map = [[None] * MAP_WIDTH] * MAP_HEIGHT
正確的方法應該是:
dungeon_map = [[None] * MAP_HEIGHT] * MAP_WIDTH
既然你做到了,讓我們來看看第二個更嚴重的問題。 讓我們在較小的比例(較小的地圖)上進行一個實驗:
MAP_WIDTH = 4
MAP_HEIGHT = 2
dungeon_map = [[None] * MAP_HEIGHT] * MAP_WIDTH
print('\nBefore Assignment:')
print(dungeon_map)
dungeon_map[2][1] = 'y'
print('\nAfter Assignment:')
print(dungeon_map)
在這個實驗中,我們創建了一個 4 列 x 2 行的矩陣,我們改變了一個單元格的值,讓我們看看輸出:
Before Assignment:
[[None, None], [None, None], [None, None], [None, None]]
After Assignment:
[[None, 'y'], [None, 'y'], [None, 'y'], [None, 'y']]
到底是怎么回事? 本質上,您聲明了相同的列表, MAP_WIDTH
次。 下面的聲明行既方便又聰明,但不正確:
dungeon_map = [[None] * MAP_HEIGHT] * MAP_WIDTH
聲明這樣一個矩陣的正確方法是:
dungeon_map = [[None for x in range(MAP_HEIGHT)] for y in range(MAP_WIDTH)]
聲明:本站的技術帖子網頁,遵循CC BY-SA 4.0協議,如果您需要轉載,請注明本站網址或者原文地址。任何問題請咨詢:yoyou2525@163.com.