[英]IndexError: list index out of range in a matrix
I've been trying to create a Procedurally Generated Dungeon, as seen in this article .我一直在尝试创建一个程序生成的地牢,如本文所示。 But that was a little to hard for me to understand the working this type of algorithm.
但这对我来说有点难以理解这种算法的工作原理。 So instead, I've been using this as a guide to at least understand the room placement.
所以相反,我一直在使用它作为至少了解房间布置的指南。
The program used in the article is made in Java, so I made some adaptations to my "reality", and tried to emulate the same results in Python 3.5.文章中使用的程序是用Java编写的,所以我根据自己的“现实”做了一些改编,并尝试在Python 3.5中模拟出同样的结果。
My code is as follows:我的代码如下:
from random import randint
class Room:
"""docstring for Room"""
def __init__(self, x, y, w, h):
"""[summary]
[description]
Arguments:
x {int} -- bottom-left horizontal anchorpoint of the room
y {int} -- bottom-left vertical anchor point of the room
w {int} -- width of the room
h {int} -- height of the room
"""
self.x1 = x
self.x2 = x + w
self.y1 = y
self.y2 = y + h
self.w = w
self.h = h
self.center = ((self.x1 + self.x2)/2, (self.y1 + self.y2)/2)
def intersects(self, room):
"""[summary]
Verifies if the rooms overlap
Arguments:
room {Room} -- a room object
"""
return(self.x1 <= room.x2 and self.x2 >= room.x1 and \
self.y1 <= room.y2 and self.y2 >= room.y1)
def __str__(self):
room_info = ("Coords: (" + str(self.x1) + ", " + str(self.y1) +
") | (" + str(self.x2) + ", " + str(self.y2) + ")\n")
room_info += ("Center: " + str(self.center) + "\n")
return(room_info)
MIN_ROOM_SIZE = 10
MAX_ROOM_SIZE = 20
MAP_WIDTH = 400
MAP_HEIGHT = 200
MAX_NUMBER_ROOMS = 20
dungeon_map = [[None] * MAP_WIDTH for i in range(MAP_HEIGHT)]
# print(dungeon_map)
def crave_room(room):
"""[summary]
"saves" a room in the dungeon map by making everything inside it's limits 1
Arguments:
room {Room} -- the room to crave in the dungeon map
"""
for x in xrange(min(room.x1, room.x2), max(room.x1, room.x2) + 1):
for y in xrange(min(room.y1, room.y2), max(room.y1, room.y2) + 1):
print(x, y) # debug
dungeon_map[x][y] = 1
print("Done") # dungeon
def place_rooms():
rooms = []
for i in xrange(0, MAX_NUMBER_ROOMS):
w = MIN_ROOM_SIZE + randint(0, MAX_ROOM_SIZE - MIN_ROOM_SIZE + 1)
h = MIN_ROOM_SIZE + randint(0, MAX_ROOM_SIZE - MIN_ROOM_SIZE + 1)
x = randint(0, MAP_WIDTH - w) + 1
y = randint(0, MAP_HEIGHT - h) + 1
new_room = Room(x, y, w, h)
fail = False
for other_room in rooms:
if new_room.intersects(other_room):
fail = True
break
if not fail:
print(new_room)
crave_room(new_room) # WIP
new_center = new_room.center
# rooms.append(new_room)
if len(rooms) != 0:
prev_center = rooms[len(rooms) - 1].center
if(randint(0, 1) == 1):
h_corridor(prev_center[0], new_center[0], prev_center[1])
v_corridor(prev_center[1], new_center[1], prev_center[0])
else:
v_corridor(prev_center[1], new_center[1], prev_center[0])
h_corridor(prev_center[0], new_center[0], prev_center[1])
if not fail:
rooms.append(new_room)
for room in rooms:
print(room)
def h_corridor(x1, x2, y):
for x in xrange(min(x1, x2), max(x1, x2) + 1):
dungeon_map[x][y] = 1
def v_corridor(y1, y2, x):
for y in xrange(min(y1, y2), max(y1, y2) + 1):
dungeon_map[x][y] = 1
place_rooms()
but whenever I run it, I get the following error:但是每当我运行它时,都会出现以下错误:
Traceback (most recent call last):
File "/home/user/dungeon.py", line 114, in <module>
place_rooms()
File "/home/user/dungeon.py", line 87, in place_rooms
crave_room(new_room)
File "/home/user/dungeon.py", line 65, in crave_room
dungeon_map[x][y] = 1
IndexError: list index out of range
For what I understood from my code, the crave_room
function should work correctly, since I'm using the min
and max
functions.根据我从代码中的理解,
crave_room
函数应该可以正常工作,因为我使用的是min
和max
函数。 And since the h_corridor
and v_corridor
functions work in a similar way They present the same kind of problem.并且由于
h_corridor
和v_corridor
函数以类似的方式工作,因此它们存在相同类型的问题。
I'm not sure if the problem is happening due the fact that I'm using a matrix as a substitute to the canvas used in the original article.我不确定问题是否发生,因为我使用矩阵代替原始文章中使用的画布。 I was suspecting a local/global variable problem, but I don't think that's the problem.
我怀疑是局部/全局变量问题,但我认为这不是问题所在。 I'm afraid I'm making a very stupid mistake and not seeing it.
恐怕我犯了一个非常愚蠢的错误而没有看到它。
Any code improvement tips or suggestions about better data structures to use will be welcome, and if anyone has, a more clearer/simpler article in the subject, preferably on Python, I saw a lot of the related posts in here, but I'm still kind of lost.欢迎任何关于更好的数据结构使用的代码改进技巧或建议,如果有人有关于该主题的更清晰/更简单的文章,最好是关于 Python,我在这里看到了很多相关的帖子,但我还是有点失落。
Thanks for any help.谢谢你的帮助。 :D
:D
You have your dungeon_map
declared incorrectly:您的
dungeon_map
声明不正确:
dungeon_map = [[None] * MAP_WIDTH] * MAP_HEIGHT
The correct way should be:正确的方法应该是:
dungeon_map = [[None] * MAP_HEIGHT] * MAP_WIDTH
Now that you done that, let's take a look at the second, more serious problem.既然你做到了,让我们来看看第二个更严重的问题。 Let's have an experiment in smaller scale (smaller map):
让我们在较小的比例(较小的地图)上进行一个实验:
MAP_WIDTH = 4
MAP_HEIGHT = 2
dungeon_map = [[None] * MAP_HEIGHT] * MAP_WIDTH
print('\nBefore Assignment:')
print(dungeon_map)
dungeon_map[2][1] = 'y'
print('\nAfter Assignment:')
print(dungeon_map)
In this experiment, we created a 4 column x 2 row matrix and we alter the value of one cell, so let's take a look at the output:在这个实验中,我们创建了一个 4 列 x 2 行的矩阵,我们改变了一个单元格的值,让我们看看输出:
Before Assignment:
[[None, None], [None, None], [None, None], [None, None]]
After Assignment:
[[None, 'y'], [None, 'y'], [None, 'y'], [None, 'y']]
What is going on?到底是怎么回事? Essentially, you declare the same list,
MAP_WIDTH
times.本质上,您声明了相同的列表,
MAP_WIDTH
次。 The declaration line below is convenient and clever, but incorrect:下面的声明行既方便又聪明,但不正确:
dungeon_map = [[None] * MAP_HEIGHT] * MAP_WIDTH
The correct way to declare such a matrix is:声明这样一个矩阵的正确方法是:
dungeon_map = [[None for x in range(MAP_HEIGHT)] for y in range(MAP_WIDTH)]
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.