[英]c# refactor code via parameter
我想知道這兩種方法基本相同,我想知道是否有可能引入新的參數來使這兩種方法合而為一
方法:
public string CodeAnalysisEnabled(XElement propertyGroup, string groupName)
{
var codeAnalysis = (from doc in propertyGroup?.Descendants("RunCodeAnalysis") select doc).ToArray();
if (codeAnalysis.Length == 0)
{
return groupName + ": RunCodeAnalysis is missing.";
}
var allOk = codeAnalysis.All(n => n.Value.Equals("true", StringComparison.InvariantCultureIgnoreCase));
return allOk ? null : groupName + ": RunCodeAnalysis has wrong state.";
}
public string WarningsAsErrorsEnabled(XElement propertyGroup, string groupName)
{
var codeAnalysis = (from doc in propertyGroup?.Descendants("TreatWarningsAsErrors") select doc).ToArray();
if (codeAnalysis.Length == 0)
{
return groupName + ": TreatWarningsAsErrors is missing.";
}
var allOk = codeAnalysis.All(n => n.Value.Equals("true", StringComparison.InvariantCultureIgnoreCase));
return allOk ? null : groupName + ": TreatWarningsAsErrors has wrong state.";
}
是的,您只能傳遞一個差異作為參數:
public string MeaningfulMethodName(XElement propertyGroup, string groupName, string propertyName)
{
var codeAnalysis = (from doc in propertyGroup?.Descendants(propertyName) select doc).ToArray();
if (codeAnalysis.Length == 0)
{
return $"{groupName}: {propertyName} is missing.";
}
var allOk = codeAnalysis.All(n => n.Value.Equals("true", StringComparison.InvariantCultureIgnoreCase));
return allOk ? null : $"{groupName}: {propertyName} has wrong state.";
}
那這個呢?
public string CodeAnalysisEnabled(XElement propertyGroup, string groupName)
{
return Check(propertyGroup, groupName, "RunCodeAnalysis");
}
public string WarningsAsErrorsEnabled(XElement propertyGroup, string groupName)
{
return Check(propertyGroup, groupName, "TreatWarningsAsErrors");
}
private static string Check(XElement propertyGroup, string groupName, string checkedParam)
{
var codeAnalysis = (from doc in propertyGroup?.Descendants(checkedParam) select doc).ToArray();
if (codeAnalysis.Length == 0)
{
return groupName + $": {checkedParam} is missing.";
}
var allOk = codeAnalysis.All(n => n.Value.Equals("true", StringComparison.InvariantCultureIgnoreCase));
return allOk ? null : groupName + $": {checkedParam} has wrong state.";
}
聲明:本站的技術帖子網頁,遵循CC BY-SA 4.0協議,如果您需要轉載,請注明本站網址或者原文地址。任何問題請咨詢:yoyou2525@163.com.