[英]C# MVC Mock Model through interface brokes the controller
我在控制器中有這個方法:
[HttpPatch]
[AllowAdminOnly]
public JsonResult EditUser(User _user)
{
try
{
if (ModelState.IsValid)
{
_user.Edit();
}
else
{
string error_messages = "";
foreach (var e in ModelState.Select(x => x.Value.Errors).Where(y => y.Count > 0).ToList())
{
error_messages += e[0].ErrorMessage + "\n";
}
throw new Exception(error_messages);
}
return MessageHelper(@Resources.Global.success, @Resources.Users.success_editing_user, "success");
}
catch (Exception err)
{
return ErrorHelper(@Resources.Global.error, @Resources.Users.error_editing_user, err.Message);
}
}
為了對該方法進行單元測試,我發現參考文獻 (...) 說我應該“模擬” _user.Edit();
. 看起來不錯,它將避免將數據保存到數據庫並使測試更快。
我的測試然后(對於有效用戶)變為:
[TestMethod]
public void UserController_EditUser_Valid()
{
// Arrange
FundController controller = new UserController();
controller.ControllerContext = TestModelHelper.AdminControllerContext();
var _user = new Mock<Fund>();
_user.SetupGet(f => f.id).Returns(1);
_user.SetupGet(f => f.name).Returns("User name");
_user.SetupGet(f => f.nickname).Returns("User nickname");
_user.SetupGet(f => f.active).Returns(true);
_user.Setup(f => f.Edit()).Callback(() => {}).Verifiable();
// Act
var result = (JsonResult)controller.EditUser(_user.Object);
SimpleMessage resultMessage = m_serializer.Deserialize<SimpleMessage>(m_serializer.Serialize(result.Data));
// Assert
Assert.IsNotNull(resultMessage, "Result must not be null");
Assert.IsTrue(resultMessage.status.Equals("success"), "status must be 'success'");
}
但是當我這樣做時,我收到以下錯誤:
Test Name: UserController_EditUser_Valid
Test FullName: Pmanager.Tests.Controllers.UserControllerTest.UserController_EditUser_Valid
Test Source: ...\Pmanager\Pmanager.Tests\Controllers\UserControllerTest.cs : line 95
Test Outcome: Failed
Test Duration: 0:00:00,0179908
Result StackTrace:
em Moq.Mock.ThrowIfCantOverride(Expression setup, MethodInfo method)
em Moq.Mock.<>c__DisplayClass66_0`2.<SetupGet>b__0()
em Moq.PexProtector.Invoke[T](Func`1 function)
em Moq.Mock.SetupGet[T,TProperty](Mock`1 mock, Expression`1 expression, Condition condition)
em Moq.Mock`1.SetupGet[TProperty](Expression`1 expression)
em Pmanager.Tests.Controllers.UserControllerTest.UserController_EditUser_Valid() na ...\Pmanager\Pmanager.Tests\Controllers\UserControllerTest.cs:linha 100
Result Message:
Test method Pmanager.Tests.Controllers.UserControllerTest.UserController_EditUser_Valid threw exception:
System.NotSupportedException: Valid setup on a non-virtual (overridable in VB) member: f => f.id
我發現了一些關於 (...) 的文檔,說我應該在創建"mock"時使用接口而不是類。
所以,我創建了一個界面:
public interface IUser
{
int id { get; set; }
string name { get; set; }
string nickname { get; set; }
bool active { get; set; }
void Edit();
}
然后我改變了IUser
所有內容,控制器的方法簽名:
public JsonResult EditUser(IUser _user);
測試“模擬”聲明:
var _user = new Mock<IUser>();
等等。
現在測試成功了,但實際控制器編輯用戶的方法沒有!
如何在不破壞控制器真正功能的情況下將所有這些東西放在一起?
更新控制器以使用依賴項來更新用戶模型。 從模型本身中刪除該功能。 模型應該是 POCO/DTO。
public class UserController : Controller {
readonly IUserService userService;
public UserController(IUSerService userService) {
this.userService = userService;
}
[HttpPatch]
[AllowAdminOnly]
public JsonResult EditUser(User _user) {
try {
if (ModelState.IsValid) {
userService.Edit(user);
} else {
string error_messages = "";
foreach (var e in ModelState.Select(x => x.Value.Errors).Where(y => y.Count > 0).ToList()) {
error_messages += e[0].ErrorMessage + "\n";
}
throw new Exception(error_messages);
}
return MessageHelper(@Resources.Global.success, @Resources.Users.success_editing_user, "success");
} catch (Exception err) {
return ErrorHelper(@Resources.Global.error, @Resources.Users.error_editing_user, err.Message);
}
}
}
IUserService
是這樣的
public interface IUserService {
void Edit(User user);
}
並且其生產實施將執行所需的操作。 請記住使用您正在使用的任何 DI 注冊抽象和實現。
然后,測試將模擬其獨立運行所需的依賴項。
[TestMethod]
public void UserController_EditUser_Should_Be_Valid() {
// Arrange
var _user = new User {
id = 1,
name = "User name",
nickname = "User nickname",
active = true
};
var mockService = new Mock<IUserService>();
mockService .Setup(m => m.Edit(_user)).Verifiable();
var controller = new UserController(mockService.Object);
controller.ControllerContext = TestModelHelper.AdminControllerContext();
// Act
var result = controller.EditUser(_user) as JsonResult;
// Assert
Assert.IsNotNull(result, "Result must not be null");
mockService.Verify(); // verify that the service was call successfully.
}
好吧,我仍然懷疑做這一切的正確方法。
但我想出了一種讓兩者都工作的方法。 這是:
public JsonResult EditUser(User _user);
var result = (JsonResult)controller.EditUser(_user.Object as User);
雖然它有效,但我不確定整個事情是否和諧...... :(
希望有人能給出更好的答案。
聲明:本站的技術帖子網頁,遵循CC BY-SA 4.0協議,如果您需要轉載,請注明本站網址或者原文地址。任何問題請咨詢:yoyou2525@163.com.