[英]I keep getting a std::bad_alloc error in C++
所以我正在為 Project Euler #14 制作一個程序,我有這個
#include <iostream>
#include <vector>
using namespace std;
vector <int> CollatzSequence (int n)
{
vector <int> numbers;
int currentNumber = n;
while (currentNumber != 1) {
numbers.push_back(n);
if (currentNumber%2 == 0) {
currentNumber /= 2;
} else {
currentNumber *= 3;
currentNumber += 1;
}
}
numbers.push_back(1);
return numbers;
}
int main()
{
int largestNumber = 0;
int currentNumber = 2;
while (currentNumber < 1000000) {
if (CollatzSequence(currentNumber).size() > largestNumber) {
largestNumber = currentNumber;
}
currentNumber++;
}
cout << largestNumber;
return 0;
}
但我不斷收到此錯誤
terminate called after throwing an instance of 'std::bad_alloc'
what(): std::bad_alloc
我是 C++ 的新手,但我不知道這個錯誤是什么意思或如何修復它。 有誰知道如何解決這一問題?
當分配 memory 失敗時拋出std::bad_alloc
,在您的代碼中,當為返回的std::vector
分配 memory 時會發生這種情況。 std::vector
需要連續的 memory,在您的代碼中,要分配的大小可能會導致問題。
正如@WhozCraig 在評論中所說,function 不需要返回向量本身,因為只使用了大小,只需在 function 內添加一個計數器並返回它。
#include <iostream>
#include <vector>
using namespace std;
int CollatzSequence(int n)
{
int currentNumber = n;
int counter = 0;
while (currentNumber != 1) {
++counter;
if (currentNumber%2 == 0) {
currentNumber /= 2;
} else {
currentNumber *= 3;
currentNumber += 1;
}
}
++counter;
return counter;
}
int main()
{
int largestNumber = 0;
int currentNumber = 2;
while (currentNumber < 1000000) {
if (CollatzSequence(currentNumber) > largestNumber) {
largestNumber = currentNumber;
}
currentNumber++;
}
cout << largestNumber;
return 0;
}
也許還可以考慮從int
移動到std::uint64_t
就像評論中建議的@Pablochaches
聲明:本站的技術帖子網頁,遵循CC BY-SA 4.0協議,如果您需要轉載,請注明本站網址或者原文地址。任何問題請咨詢:yoyou2525@163.com.