為什么我的戰艦游戲代碼會一遍又一遍地運行？

Question

所以我試圖在 python 中創建一個非常簡單的單人戰艦游戲。 計算機隨機將它的船放置在行和列中，玩家猜測船在哪一行和哪一列。我目前的問題是我的代碼是這樣做的，但是它每次都會打印出棋盤，而且似乎也使玩家的選擇也是如此。

import random
#Make board
board = [
    [' ', ' ', ' ', ' ', ' '],
    [' ', ' ', ' ', ' ', ' '],
    [' ', ' ', ' ', ' ', ' '],
    [' ', ' ', ' ', ' ', ' '],
    [' ', ' ', ' ', ' ', ' '],
]

# List to refer to columns by letter, since that is how a typical battleship game is
#initiated
letters2Numbers = {
    'A': 0,
    'B': 1,
    'C': 2,
    'D': 3,
    'E': 4,
}


#Function to ask the user for their board position
def generateShips():
    for a in range (0,55):
        row = random.randrange(1,6)
        column = random.choice(['A','B','C','D','E'])
        rowNumber = row
        columnNumber = column

        return int(row) - 1, letters2Numbers[column]

def askUser():
    column = input("column (A to E):")
    while column not in "ABCDE":
        print("That column is wrong! It should be A, B, C, D or E")
        column = input("column (A to E):")

    row = input("row (1 to 5):")
    while row not in "12345":
        print("That row is wrong! it should be 1, 2, 3, 4 or 5")
        row = input("row (1 to 5):")
    return int(row) - 1, letters2Numbers[column]

def printBoard(board):
    # Shows the board, one row at a time, labelled
    print("  A B C D E")
    print(" +-+-+-+-+-+")
    rowNumber = 1
    for row in board:
        print("%d|%s|" % (rowNumber, "|".join(row)))
        print(" +-+-+-+-+-+")
        rowNumber = rowNumber + 1




# Now clear the screen, and the other player starts guessing
print("\n"*50)

guessesBoard = [
    [' ', ' ', ' ', ' ', ' '],
    [' ', ' ', ' ', ' ', ' '],
    [' ', ' ', ' ', ' ', ' '],
    [' ', ' ', ' ', ' ', ' '],
    [' ', ' ', ' ', ' ', ' '],
]


# Keep playing until we have 5 right guesses
guesses = 0
while guesses < 5:
    print("Guess a battleship location")
    rowNumber, columnNumber = askUser()

    if guessesBoard[rowNumber][columnNumber] != ' ':
        print("You have already guessed that place!")
        continue

    # Check that there are no repeats
    if board[rowNumber][columnNumber] == 'X':
        print("HIT!")
        guessesBoard[rowNumber][columnNumber] = 'X'
        guesses = guesses + 1
    else:
        guessesBoard[rowNumber][columnNumber] = '.'
        print("MISS!")

    printBoard(guessesBoard)
print("GAME OVER!")

到目前為止，這是我的代碼。 如果你運行它，你會看到我所說的錯誤。

Answer 1

你從不要求玩家選擇； 您打印一條消息，暗示您即將這樣做，但隨后您的代碼提前收費並使用船舶生成的行和列。 您的程序中沒有任何地方接受用戶輸入。

Answer 2

您想使用 function input() 而不是 random.SOMETHING。 那么您的輸入將不會被 PC 選擇。

然后要將用戶輸入（始終返回字符串）轉換為數字，您可以使用以下內容：

a = input("perhaps a number: ")
if not a.isdigit():
    raise ValueError("I said number :(")
a = int(a)

您可能不想引發錯誤，我只是在展示您可以構建的內容。

我正在等待這個問題的進一步發展。 :)