Groovy Spock：如何在不立即拋出錯誤的情況下將新異常傳入 when 方法

Question

我正在嘗試測試一個接受Exception的 kafka 錯誤處理程序，但是一旦我在 spock 中聲明它，它實際上就會拋出它。

def 'test example'() {
    when:
    service.emitError(new Exception('test exception'))

    then:
    // do some tests
}

我試過在一個包裝的 java 類中聲明它並在 main 中運行它不會拋出錯誤，但如果我將它拉入 spock 它將錯誤地處理它。

我想看看是我做錯了還是我不能用 spock 測試這個。

Answer 1

在 Jeff 的幫助下，我意識到這是模擬 kafka 模板的錯誤。 當您必須將異常傳遞到模擬中（不確定它是否只是KafkaTemplate特定的）並且預期的模擬失敗時，某些東西冒泡了，而我的 try catch 卻抓住了它。 我知道我應該發布原始代碼 - 並且將來會發布。 這是對沒有測試的預重構代碼（不是 TTD）的測試

我錯過了失敗的.key('key') 。

發射器

public class KafkaErrorNotificationEmitter {
    private final KafkaTemplate<String, TopicMessageData> kafkaTemplate;
    private final ObjectMapper objectMapper;
    private final TemporalConfig.TimeKeeper timeKeeper;
    private final String internalErrorTopic;

    public KafkaErrorNotificationEmitter(
        KafkaTemplate<String, TopicMessageData> kafkaTemplate,
        ObjectMapper objectMapper,
        TemporalConfig.TimeKeeper timeKeeper,
        @Value("${kafka.error.topic}") String internalErrorTopic
    ) {
        this.kafkaTemplate = kafkaTemplate;
        this.objectMapper = objectMapper;
        this.timeKeeper = timeKeeper;
        this.internalErrorTopic = internalErrorTopic;
    }

    public void emitError(@Nullable KesMessageProperties kesMessageProperties, Exception ex) {
        assert kesMessageProperties != null;
        String entityName = kesMessageProperties.getEntityName();

        log.warn("Failed message ({}). Sending to KES.", entityName, ex);

        String key = kesMessageProperties.getMessage().getKey();

        try {
            TopicMessageData errorMessage =
                TopicMessageData
                    .builder()
                    .sourceTopic(kesMessageProperties.getTopic())
                    .exceptionMessage(ex.getMessage())
                    .key(key)
                    .listenerType(kesMessageProperties.getListenerType())
                    .occurrenceTime(timeKeeper.nowZdt())
                    .payload(objectMapper.writeValueAsString(kesMessageProperties.getMessage()))
                    .build();

            sendEmitError(errorMessage);
        } catch (Exception e) {
            log.error("Failed to send error ({}) notification for {}", entityName, key, e);
        }
    }

    private void sendEmitError(final TopicMessageData topicMessageData) {
        log.debug("Sending error message for: {}", topicMessageData);
        kafkaTemplate.send(internalErrorTopic, topicMessageData);
    }

}

測試

class KafkaErrorNotificationEmitterSpec extends Specification {
    KafkaTemplate<String, TopicMessageData> kafkaTemplate = Mock()
    ObjectMapper objectMapper = new ObjectMapper()
    TemporalConfig.TimeKeeper timeKeeper = Mock()
    String internalErrorTopic = 'kes.error.test'

    def kafkaErrorNotificationEmitter = new KafkaErrorNotificationEmitter(
        kafkaTemplate,
        objectMapper,
        timeKeeper,
        internalErrorTopic
    )

    @Shared
    def errorMessage = 'Test exception'

    @Shared
    Exception exception = new Exception(errorMessage)

    def 'emitError throws uncaught NPE'() {
        setup:
        def properties = new KesMessageProperties(message: null)

        when:
        kafkaErrorNotificationEmitter.emitError(properties, exception)

        then:
        0 * _
        thrown NullPointerException
    }

    def 'emitError throws caught exception'() {
        setup:
        def properties = new KesMessageProperties(
            message: new IKafkaMessage() {
                @Override
                String getKey() {
                    return null
                }
            }
        )

        when:
        kafkaErrorNotificationEmitter.emitError(properties, exception)

        then:
        1 * timeKeeper.nowZdt() >> { throw new RuntimeException() }
        0 * _
    }

    def 'emitError success'() {
        setup:
        def listenerType = 'test-error'

        def properties = new KesMessageProperties(
            listenerType: listenerType,
            message: new IKafkaMessage() {
                @Override
                String getKey() {
                    return 'key'
                }
            }
        )

        def now = ZonedDateTime.now()

        def errorData =
            TopicMessageData
                .builder()
                .exceptionMessage(errorMessage)
                .listenerType(listenerType)
                //.key('key') // this is what was missing!!!
                .occurrenceTime(now)
                .payload('{\"key\":\"key\"}')
                .build()

        when:
        kafkaErrorNotificationEmitter.emitError(properties, exception)

        then:
        1 * timeKeeper.nowZdt() >> now
        1 * kafkaTemplate.send(internalErrorTopic, errorData) >> Mock(ListenableFuture)
    }
}