簡化[C＃]

Question

這可能寫的很簡單，代碼在這里：

foreach (var friend in friends)
{
    friend.Value.blockQuote = GetBlockQuote(friend.Value.nick);

    if (friend.Value.photo == "0")
    {
        if (friend.Value.sex == 1)
        {
            var img = new BitmapImage();
            img.BeginInit();
            img.UriSource = new Uri(@"avatars\man.jpg",
                                    UriKind.Relative);
            img.EndInit();
            friend.Value.profilePhoto = img;
        }
        if (friend.Value.sex == 2)
        {
            //da default
            var img = new BitmapImage();
            img.BeginInit();
            img.UriSource = new Uri(@"avatars\woman.jpg",
                                    UriKind.Relative);
            img.EndInit();
            friend.Value.profilePhoto = img;
        }
    }
    else
    {
        var img = new BitmapImage();
        img.BeginInit();
        img.UriSource = new Uri(friend.Value.photo.Replace(@"\", "").Replace(@"s_", ""), UriKind.Absolute);
        img.EndInit();
        friend.Value.profilePhoto = img;
    }
}

Answer 1

突破uri設置部分

foreach (var friend in friends)
{
    friend.Value.blockQuote = GetBlockQuote(friend.Value.nick);

    Uri uri;
    if (friend.Value.photo == "0")
    {
        if (friend.Value.sex == 1)
        {
            uri = new Uri(@"avatars\man.jpg", UriKind.Relative);
        }
        else if (friend.Value.sex == 2)
        {
            //da default
            uri = new Uri(@"avatars\woman.jpg", UriKind.Relative);
        }
        else
        {
            uri = null; // insert error handling here
        }
    }
    else
    {
        uri = new Uri(friend.Value.photo.Replace(@"\", "").Replace(@"s_", ""), UriKind.Absolute);
    }
    var img = new BitmapImage();
    img.BeginInit();
    img.UriSource = uri;
    img.EndInit();
    friend.Value.profilePhoto = img;
}

編輯
注意，if-else-part現在是Refactor-> Extract方法的良好候選者

Answer 2

您可以排除界限

var img = new BitmapImage();
img.BeginInit();

和

img.EndInit();
friend.Value.profilePhoto = img;

通過將它們放在（對於前者）之前（對於后者）在if / else塊之后。

Answer 3

foreach (var friend in friends)
{
    friend.Value.blockQuote = GetBlockQuote(friend.Value.nick);
    var img = new BitmapImage();
    img.BeginInit();

    if (friend.Value.photo == "0")
    {
        if (friend.Value.sex == 1)
        {
             img.UriSource = new Uri(@"avatars\man.jpg",
        }
        if (friend.Value.sex == 2)
        {
             img.UriSource = new Uri(@"avatars\woman.jpg",
                                                UriKind.Relative);
        }
     }
     else
     {
          img.UriSource = new Uri(friend.Value.photo.Replace(@"\", "").Replace(@"s_", ""), UriKind.Absolute);

     }

     img.EndInit();
     friend.Value.profilePhoto = img;
}