尝试将mysql_ *重写为pdo

Question

First of all I should say that I started to learn PDO and trying to rewrite some old mine codes. Here is one that I found on tutorial for a jquery/ajax/pdo/mysql comment system which is working. This is the mysql_* part which I'm trying to rewrite -> file submit.php which submits the comments to database.

$arr = array();
$validates = Comment::validate($arr);

if($validates)
{
   /* Everything is OK, insert to database: */

   mysql_query("    INSERT INTO comments(name,url,email,body)
                VALUES (
                    '".$arr['name']."',
                    '".$arr['url']."',
                    '".$arr['email']."',
                    '".$arr['body']."'
                )");

  $arr['dt'] = date('r',time());
  $arr['id'] = mysql_insert_id();

  $arr = array_map('stripslashes',$arr);

  $insertedComment = new Comment($arr);

  /* Outputting the markup of the just-inserted comment: */

  echo json_encode(array('status'=>1,'html'=>$insertedComment->markup()));

}
else
{
    /* Outputtng the error messages */
    echo '{"status":0,"errors":'.json_encode($arr).'}';
}

Here is my try of this piece of code.

$pdo = Database::connect();
$arr = array();
$validates = Comment::validate($arr);

if($validates)
{
     /* Everything is OK, insert to database: */
     $sql = $pdo->prepare("INSERT INTO comments ( name,url,email,body ) 
                            VALUES (:name, :url, :email, :body)");

                        $sql->execute(array(
                        ':name'     => $name,
                        ':url'          => $url,
                        ':email'    => $email,
                        ':body'     => $body

                        ));
     $arr['dt'] = date('r',time());
     $arr['id'] = $pdo->lastInsertId();

     $arr = array_map('stripslashes',$arr);

     $insertedComment = new Comment($arr);

     /* Outputting the markup of the just-inserted comment: */

     echo json_encode(array('status'=>1,'html'=>$insertedComment->markup()));

}
else
{
    /* Outputtng the error messages */
    echo '{"status":0,"errors":'.json_encode($arr).'}';
}

When I hit button Submit just nothing happen. Didn't insert anything into database. And the button become inactive.

If need I can show javascript part or the form as well. Thank's

UPDATE: This is the comment.class.php which is included also into the submit.php

class Comment
{
    private $data = array();

    public function __construct($row)
    {   
       /*
       /    The constructor
       */

       $this->data = $row;
    }

    public function markup()
    {
       // this just output the comment on page nothing special some html
    }

    public static function validate(&$arr)
    {

       $errors = array();
       $data    = array();

       // Using the filter_input function introduced in PHP 5.2.0

       if(!($data['email'] = filter_input(INPUT_POST,'email',FILTER_VALIDATE_EMAIL)))
       {
            $errors['email'] = 'Wrong email.';
       }

       if(!($data['url'] = filter_input(INPUT_POST,'url',FILTER_VALIDATE_URL)))
       {
            // If the URL field was not populated with a valid URL,
            // act as if no URL was entered at all:

            $url = '';
       }

    // Using the filter with a custom callback function:

       if(!($data['body'] = filter_input(INPUT_POST,'body',FILTER_CALLBACK,array('options'=>'Comment::validate_text'))))
       {
           $errors['body'] = 'Please enter your comment.';
       }

       if(!($data['name'] = filter_input(INPUT_POST,'name',FILTER_CALLBACK,array('options'=>'Comment::validate_text'))))
       {
           $errors['name'] = 'Please enter your name.';
       }

       if(!empty($errors)){

        // If there are errors, copy the $errors array to $arr:

        $arr = $errors;
        return false;
       }  

       // If the data is valid, sanitize all the data and copy it to $arr:

       foreach($data as $k=>$v){
           $arr[$k] = mysql_real_escape_string($v);
       }

       $arr['email'] = strtolower(trim($arr['email']));

       return true;     
    } 

   private static function validate_text($str)
   {

      if(mb_strlen($str,'utf8')<1)
        return false;           

      $str = nl2br(htmlspecialchars($str));

      // Remove the new line characters that are left
      $str = str_replace(array(chr(10),chr(13)),'',$str);

      return $str;
   }
}

Answer 1

I don't know the source of the array $arr = array(); , but it is assigned to null before the insert query. So it means, literally you are inserting nothing into the database. So check your array well, maybe it was to be like

$arr = array('name'=>'My Name', 'url'=>'url', 'email'=>'my email', 'body'=>'comment');

And if there is nothing wrong with your array then I think you are missing the keys of the array. You can either store the array values into variables or use them straight away. So use ,

$pdo = Database::connect();
$arr = array();
$validates = Comment::validate($arr);

if($validates)
{
 /* Everything is OK, insert to database: */
 $sql = $pdo->prepare("INSERT INTO comments ( name,url,email,body ) 
                        VALUES (:name, :url, :email, :body)");

                    $sql->execute(array(
                    ':name'     => $arr['name'],
                    ':url'      => $arr['url'],
                    ':email'    => $arr['email'],
                    ':body'     => $arr['body']

                    ));
 $arr['dt'] = date('r',time());
 $arr['id'] = $pdo->lastInsertId();

 $arr = array_map('stripslashes',$arr);

 $insertedComment = new Comment($arr);

 /* Outputting the markup of the just-inserted comment: */

 echo json_encode(array('status'=>1,'html'=>$insertedComment->markup()));

}
else
{
/* Outputtng the error messages */
echo '{"status":0,"errors":'.json_encode($arr).'}';
}

I hope it will help.