[英]strcat() concatenating to two strings
I am trying to concatenate a card ex."10" "1" "A" to the string "pile".我正在尝试将卡片 ex."10" "1" "A" 连接到字符串“pile”。 This is a very simplified version of Blackjack, so it is not concerned with the suits of the cards and deals one card at a time.这是一个非常简化的二十一点版本,因此它不关心牌的花色,一次发一张牌。
However when I run it, it adds the card to a pile string that was not passed into the method.但是,当我运行它时,它会将卡片添加到未传递给方法的堆字符串中。
I made a minimal recreation of the problem我对这个问题做了一个最小的娱乐
#include <stdio.h>
#include <stdlib.h>
#include <time.h>
#include <string.h>
int placeCard(char *pile, char *card)
{
//removed code for minimal recreation of problem
//no piles finished
strcat(pile, card);
return 0;
}
int main()
{
char card[4];
char pile1[] = "";
char pile2[] = "";
char pile3[] = "";
char pile4[] = "";
char pile5[] = "";
char faces[13][4] = {" 2", " 3", " 4", " 5", " 6", " 7", " 8", " 9", " 10", " J", " Q", " K", " A"};
while(1)
{
// print current state of game
printf("Pile (1): %-20s \n", pile1);
printf("Pile (2): %-20s \n", pile2);
printf("Pile (3): %-20s \n", pile3);
printf("Pile (4): %-20s \n", pile4);
printf("Pile (5): %-20s \n\n", pile5);
//get random card
int j = rand() % 52;
//convert to string
strcpy(card, faces[j/4]);
printf("Drawn Card: %s\n\n", card);
printf("Which pile to place card in? ");
//assume valid input (1-5) for minmal reproduction of error
int userPileChoice;
scanf("%d", &userPileChoice);
switch (userPileChoice)
{
case 1:
placeCard(pile1, card);
break;
case 2:
placeCard(pile2, card);
break;
case 3:
placeCard(pile3, card);
break;
case 4:
placeCard(pile4, card);
break;
case 5:
placeCard(pile5, card);
break;
default:
break;
}
}
}
And here is the output这是 output
Pile (1):
Pile (2):
Pile (3):
Pile (4):
Pile (5):
Drawn Card: J
Which pile to place card in? 1
Pile (1): J
Pile (2): J
Pile (3):
Pile (4):
Pile (5):
Drawn Card: 7
Which pile to place card in?
I was thinking it could possibly be the switch case inside the while loop and break is messing it up somehow, but I tried researching it and didn't see anything wrong.我在想它可能是 while 循环内的开关盒,而 break 以某种方式把它搞砸了,但我试着研究它并没有发现任何问题。 Thanks for any help.谢谢你的帮助。
This: char pile1[] = "";
这个: char pile1[] = "";
will allocate an array of size 1, which is only enough for the NUL terminator, which means that it is essentially useless.将分配一个大小为 1 的数组,仅够 NUL 终止符使用,这意味着它本质上是无用的。 Do the following change to the code:对代码进行以下更改:
#define SIZE 100
int main()
{
char card[4];
char pile1[SIZE] = "";
// Same for the rest
This will solve your problem.这将解决您的问题。 But I recommend reading about dangers with strcat
.但我建议阅读有关strcat
的危险。 Here is a related post: strcat Vs strncat - When should which function be used?这是一个相关的帖子: strcat Vs strncat - 什么时候应该使用哪个 function? And it will work它会起作用
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.