无法找出我的程序崩溃的原因

Question

Using Dev C++ on windows 7 64 bit

I was trying to implement ac program that identifies the word with most occurrences in a sentence in the most optimal way. This is what i created..

 struct word{
    char *str;
    int count;
    };

int main()
{
    struct word words[10]={0};
    int i,j,flag=0,max=0;
    char *maxw=NULL,*arr[] = {"how","do","you","do"};


    for(i=0;arr[i];i++)
    {
        flag =0;
        for(j=0;words[j].count!=0;j++)
            if(strcmp(words[j].str,arr[i]) == 0 )
            {
                words[j].count++;
                flag = 1;
                break;
            }

        if(flag == 0){  
        words[j].str = arr[i];
        words[j].count++;
        }

        if (max < words[j].count){
        max = words[j].count;
        maxw=words[j].str;
        }
    }
    printf("\nMost occurrences is of %s with %d count",maxw,max);

    getch();
    return 0;
}

What i have figured out already is that the program crashes only when the maximum occurring word is the also the last word of the sentence and this has something to do with addresses of fixed strings in the memory. But i am not sure exactly what is happening here. Also, is this a good solution to this problem or some more optimum solution exists ??

PS This is not homework i am just practicing some coding.

Answer 1

Your array of pointers is not null terminated, but in your loop you are checking for null like :

for(i=0;arr[i];i++)

So you should null terminate your arr like

char *maxw=NULL,*arr[] = {"how","do","you","do",NULL}