简体   繁体   中英

How to make this code more efficient?

As i am not very advanced in C# yet, I try to learn how to make my code more efficient. I stored a lot of strings in some of the properties.

At the start of the application, i load all the seperatie properties into the textboxes. I now ise this code to load them all:

private void LoadStoredStrings()
{
    txtT1S1.Text = Properties.Settings.Default.strT1L1;
    txtT1S2.Text = Properties.Settings.Default.strT1L2;
    txtT1S3.Text = Properties.Settings.Default.strT1L3;
    txtT1S4.Text = Properties.Settings.Default.strT1L4;
    txtT1S5.Text = Properties.Settings.Default.strT1L5;
    txtT1S6.Text = Properties.Settings.Default.strT1L6;
    txtT1S7.Text = Properties.Settings.Default.strT1L7;
    txtT1S8.Text = Properties.Settings.Default.strT1L8;
    txtT1S9.Text = Properties.Settings.Default.strT1L9;
    txtT1S10.Text = Properties.Settings.Default.strT1L10;
}

Obvious i can see the logic that each stored propertie ending with T1L1 also fits to the txt that ends with T1S1 . I just know this should be done in a more elegant and solid way than what i did now. Could anyone push me in the right direction?

you can bind your properties directly to your textboxes

<UserControl xmlns:Properties="clr-namespace:MyProjectNamespace.Properties" >


<TextBox Text="{Binding Source={x:Static Properties:Settings.Default}, Path=strT1L1, Mode=TwoWay}" />

If you can get all of those constants into a List<string> , you could use it to bind to an ItemsControl with TextBlock inside:

Code behind or View Model

private ObservableCollection<string> _defaultProperties = new ObservableCollection<string>();
public ObservableCollection<string> DefaultProperties
{
    get { return _defaultProperties; }
}

XAML

<ListBox ItemsSource="{Binding Path=DefaultProperties"}>
    <ListBox.ItemTemplate>
        <DataTemplate>
             <!--Just saying "Binding" allows binding directly to the current data context vs. a property on the data context-->
            <TextBlock Text="{Binding}"/> 
        </DataTemplate>
    </ListBox.ItemTemplate>
</ListBox>

The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.

 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM