I get NotAMockException when trying to partially mock a void method - what am I doing wrong?

Question

I'm trying to use two Mockito patterns together:

• For partially mocking, use Mockito.spy .
• For mocking methods which return void, use Mockito.doXXX(...).when(mock).method(matchers) , because you can't use Mockito.when(mock.method(matchers)) syntax for obvious reasons ( method returns void so can't be passed as an argument)

When combining them, I am facing a NotAMockException . Below is a (contrived) example which I tested using PowerMockito 1.6.2 (=Mockito 1.10.19) and JUnit 4.12, and reproduces the problem.

public class Greeter { // this is the class we will be partially mocking
    public void helloWorld(String hello, Set<String> set) {
        set.add("Hello: "+hello);
    }

    public void goodbyeWorld(String goodbye, Set<String> set) {
        set.add("Goodbye: "+goodbye);
    }
}

public class ExampleClass { // this is the class under test
    public String helloGoodbye(String input, Greeter greeter) {
        Set<String> helloSet = new HashSet<String>();
        Set<String> goodbyeSet = new HashSet<String>();
        greeter.helloWorld(input, helloSet);
        greeter.goodbyeWorld(input, goodbyeSet);
        return (helloSet.iterator().next() + ", " + goodbyeSet.iterator().next());
    }
}

public class ExampleClassTest {
    @Test
    public void test() {
        Greeter greeter = new Greeter();
        Mockito.spy(greeter);
        Mockito.doAnswer(new Answer(){ // exception thrown points to this line
            @Override
            public Void answer(InvocationOnMock invocation) throws Throwable {
                ((Set<String>)invocation.getArguments()[1]).add("Bonjour: " + invocation.getArguments()[0]);
                return null;
            }
        }).when(greeter).helloWorld(Mockito.any(String.class), Mockito.any(Set.class));

        ExampleClass example = new ExampleClass();
        String aggregateGreeting = example.helloGoodbye("Mars", greeter);
        Assert.assertEquals("Bonjour: Mars, Goodbye: Mars", aggregateGreeting);
    }
}

Here is the full error I get:

org.mockito.exceptions.misusing.NotAMockException: 
Argument passed to when() is not a mock!
Example of correct stubbing:
    doThrow(new RuntimeException()).when(mock).someMethod();
    at com.example.ajb.pmv.ExampleClassTest.test(ExampleClassTest.java:21)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
    at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
    at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:74)
    at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:211)
    at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:67)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at com.intellij.rt.execution.application.AppMain.main(AppMain.java:134)


Process finished with exit code -1

Any workarounds (other ways to achieve the goal of mocking a single void method within a class) would also be welcome!!

Answer 1

You're not passing the spy to when() . You're passing the original object.

Change the line

Mockito.spy(greeter);

to

greeter = Mockito.spy(greeter);

Mockito.spy() creates a spy object that is a copy of the original object. It doesn't modify the original object.