C# Bonus Calculator

Question

Create a Bonus Calculator program that has two overloaded methods----one that accepts the salary and bonus both expressed as doubles and one that accept the salary as a double and and the bonus as an int.

I wrote the program and I can get the bonus as an int to work but both of them as double will not work

namespace BonusCalculation
{
 class Bonus
 {
   static void Main(string[] args)
   { 
        double salary;
        int bonus;
        double bonusPercent;

        WriteLine("What is your salary?");
        salary = Convert.ToDouble(ReadLine());
        WriteLine("What is your bonus?");
        string bonusString = Console.ReadLine();
        if (int.TryParse(bonusString, out bonus))
        { CalcBonus(salary, bonus); }
        else if((double.TryParse(bonusString, out bonusPercent)))
        { CalcBonus(salary, bonusPercent); }

        WriteLine( "Your new salary is {0:c2}", CalcBonus(salary,bonus));
    }
  static double CalcBonus(double s,double b)
    {
        s = (s * b) + s;
        return s;
    }
 static double CalcBonus(double s, int b)
    {
        s = s + b;
        return s;
    }
  }
}

When I run the program with a double as the bonus it doesnt do the math. Thank for any and all help.

Answer 1

The problem is here:

    if (int.TryParse(bonusString, out bonus))
    { CalcBonus(salary, bonus); }
    else if((double.TryParse(bonusString, out bonusPercent)))
    { CalcBonus(salary, bonusPercent); }

    WriteLine( "Your new salary is {0:c2}", CalcBonus(salary,bonus));

if bonusString is not a valid integer, bonus is never set, and the last call to CalcBonus in the WriteLine uses 0 as the bonus value.

Rather then trying to infer the bonus type, have the user specify if they're entering in a percentage or a value, and only do the math once rather than doing it again the the WriteLine call.

Answer 2

 public partial class Form1 : Form
{
    // Constant field for the contribution rate
    private const decimal CONTRIB_RATE = 0.05m;

    public Form1()
    {
        InitializeComponent();
    }

    // The InputIsValid method converts the user input and stores
    // it in the arguments (passed by reference). If the conversion
    // is successful, the method returns true. Otherwise it returns
    // false.
    private bool InputIsValid(ref decimal pay, ref decimal bonus)
    {
        // Flag variable to indicate whether the input is good
        bool inputGood = false;

        // Try to convert both inputs to decimal.
        if (decimal.TryParse(grossPayTextBox.Text, out pay))
        {
            if (decimal.TryParse(bonusTextBox.Text, out bonus))
            {
                // Both inputs are good.
                inputGood = true;
            }
            else
            {
                // Display an error message for the bonus.
                MessageBox.Show("Bonus amount is invalid.");
            }
        }
        else
        {
            // Display an error message for gross pay.
            MessageBox.Show("Gross pay is invalid.");
        }

        // Return the result.
        return inputGood;
    }

    private void calculateButton_Click(object sender, EventArgs e)
    {
        // Variables for gross pay, bonus, and contributions
        decimal grossPay = 0m, bonus = 0m, contributions = 0m;

        if (InputIsValid(ref grossPay, ref bonus))
        {
            // Calculate the amount of contribution.
            contributions = (grossPay + bonus) * CONTRIB_RATE;

            // Display the contribution.
            contributionLabel.Text = contributions.ToString("c");
        }
    }

    private void exitButton_Click(object sender, EventArgs e)
    {
        // Close the form.
        this.Close();
    }
}

}