stack=java.lang.StackOverflowError: stack size 8MB

Question

I'm getting this StackOverFlow error, i understand it fully, but the issue is im not dealing with big data, So how can this error be produced ?

I have an activity, Framelayout, a fragment, 3 options.

In the fragment, when you click on one of those options, it re-create the fragment and put random numbers, the MAX is 15 , So its not that big, this error happens when the user click so fast on the options which cause this overflow.

This is the code for generating, any ideas about "enhancing" it ? i don't know if this code is a bad practice for momery using.

private static List<Integer> SavedNumbers;

public static void SetupSavedNumbersLIst(){
    SavedNumbers = new ArrayList<>();
}


static List<Integer> range;
private static void AddDiff(int mMAX){
    range = new ArrayList<>();
    for(int i = 0 ; i < mMAX ; i++){
        range.add(i);
    }

    range.removeAll(SavedNumbers);
}

private static int ReturnIfDuplic(int mMAX){
    AddDiff(mMAX);
    return new Random().nextInt(range.size());
}


public static int ReturnUniqueSavedNumber(int mMAX){
    int Random = ReturnRandom(mMAX);
    if(SavedNumbers != null && SavedNumbers.size() > 0) {
        if(DoesSavedNumberExist(Random)){
            return ReturnIfDuplic(mMAX);
        } else {
            SavedNumbers.add(Random);
            return Random;
        }
    } else if (SavedNumbers != null && SavedNumbers.size() == 0){
        SavedNumbers.add(Random);
        return Random;
    } else if( SavedNumbers == null){
        SetupSavedNumbersLIst();
        return ReturnUniqueSavedNumber(mMAX);
    } else {
        return 1;
    }
}

private static boolean DoesSavedNumberExist(int Number){
    for(int s: SavedNumbers){
        if(Number == s)
            return true;
    }
    return false;
}

private static int ReturnRandom(int mMAX){
    return new Random().nextInt(mMAX);
}

Answer 1

This line is recursing if you happen to random the same number you have already saved:

if(DoesSavedNumberExist(Random)){
    return ReturnUniqueSavedNumber(mMAX);
} 

If you have already saved 1-15, and your max is 15 this will guarantee a stack-overflow as it will never satisfy the if statement. This is also generally a bad approach of "random number no good, just try again", since as you add more and more numbers you will add more and more recursions. A better approach may be to have the random number used as an index into the possible numbers that are left to choose.

Answer 2

i encounter with same problem Stack Size 8MB. when i hit my add item api got the same error . i thought it was happening at the time of getting values from the edit text. so that i change my way and get the values in my inIT(); before service call

inIT()  
sys = input_Systolic.getText().toString();
                dys = input_Diastolic.getText().toString();
                _date = dateView.getText().toString();
                tim = time.getText().toString();

Retrofit call

 HashMap<String, Object> pMap = new HashMap<>();
         pMap.put("user_id",loginStatusModal.getUser_id());
         pMap.put("relative_id",rel_id);
         pMap.put("systolic",sys);
         pMap.put("diastolic",dys);
         pMap.put("report_date",_date);
         pMap.put("report_time",tim);

with using this i solve my stack size 8mb error.

Answer 3

I had the same problem when I was trying to pass many values using intent.putExtra() .

I resolved this by saving all the data in shared preferences. You can then access any fragments or activities required in the application in a later part.

Refer this question to learn more about saving data using shared preferences.