Uncaught Syntax error on onClick function javascript

Question

I need to output some strings in the onclick anchor function.I have used proper escaping but anyhow its returning error.

My code is:

$output .= '<a title="Minus this" href="#" onclick = removefromCart("' . $item . '", "' . $nonce . '", ' . $deductQty . ');></a>';

And also used this :

$output .= '<a title="Minus this" href="#" onclick = "removefromCart("' . $item . '", "' . $nonce . '", ' . $deductQty . ')"></a>';

But in both cases there is Uncaught SyntaxError: Unexpected token }

Answer 1

您应该使用单引号来表示HTML元素中的字符串

$output .= '<a title="Minus this" href="#" onclick = "removefromCart(\'' . $item . '\', \'' . $nonce . '\', ' . $deductQty . ')"></a>';

Answer 2

The quotes is totally wrong. Do this way, using the first one:

$output .= '<a title="Minus this" href="#" onclick=\'removefromCart("' . $item . '", "' . $nonce . '", ' . $deductQty . ');\'></a>';

See the ' s I have added and removed spaces? And please, next time, don't mingle both PHP and JavaScript. It's confusingly dangerous.

See also:

• Are single quotes allowed in HTML?
• Is there a better way to write this php code?

Answer 3

For greater than or equal to PHP5

$output .= '<a title="Minus this" href="#" onclick = removefromCart($item,$nonce,$deductQty);></a>';

For Less than PHP5 try it

$output .= '<a title="Minus this" href="#" onclick = removefromCart(' . $item . ',' . $nonce . ', ' . $deductQty . ');></a>';