issue reading from xml file c#

Question

I am trying to read from a xml file but it is not working eventhough I have been weating over it for two days, so any help would be greatly appreciated!

In Cookbook class:

  public List<Recipe> readAll()
    {
        List<Recipe> newListRecipies = new List<Recipe>();
        Recipe readRecipie = new Recipe();
        TextReader reader = null;
        try
        {
            var serializer = new XmlSerializer(typeof(Recipe));
            reader = new StreamReader(path);
            newListRecipies = BinarySerialization.ReadFromBinaryFile<List<Recipe>>(path);
            reader.Close();
            return newListRecipies;
        }
        catch (Exception e)
        {
            string error = $"An exception occured: " + e;
            Log theLog = new Log();
            theLog.LogMessage(error);
            return newListRecipies;
        }
    }

In Recipe class:

 public Recipe readOne(string name)
    {
        CookBook newCB = new CookBook();
        List<Recipe> allRecipies = newCB.readAll();
        foreach(Recipe oneRecipe in allRecipies)
        {
            if(oneRecipe.recipeName == name)
            {
                return oneRecipe;
            }
        }return newCB.defaultRecipie;
    }

I am getting the default recipe as the result everytime. I can see the the recipies are saved correctly everytime but here the code anyways:

In Recipie class:

 public void SaveRecipe(Recipe myRecepie)
    {
        CookBook theCookBook = new CookBook();
        theCookBook.Save(myRecepie);
        addFoodItem(myRecepie.recipeIngridients);
    }

In CookBook class:

  public void Save(Recipe newRecipie) 
    {
        TextWriter writer = null;
        try
        {
            var serializer = new XmlSerializer(typeof(Recipe));
            writer = new StreamWriter(path, append: true);
            serializer.Serialize(writer, newRecipie);
        }
        finally
        {
            if (writer != null)
                writer.Close();
        }
    }

And the xml file (generated by the save function in the CookBook class)

    <?xml version="1.0" encoding="utf-8"?>
    <Recipe xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
    xmlns:xsd="http://www.w3.org/2001/XMLSchema">
    <recipeName>toast</recipeName>
    <recipeType>snack</recipeType>
    <recipeIngridients>
    <string>bread</string>
    <string>butter</string>
    </recipeIngridients>
    </Recipe><?xml version="1.0" encoding="utf-8"?>
    <Recipe xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
    xmlns:xsd="http://www.w3.org/2001/XMLSchema">
    <recipeName>G&amp;T</recipeName>
    <recipeType>drink</recipeType>
    <recipeIngridients>
    <string>tonic</string>
    <string>gin</string>
    </recipeIngridients>
    </Recipe><?xml version="1.0" encoding="utf-8"?>
    <Recipe xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
    xmlns:xsd="http://www.w3.org/2001/XMLSchema">
   <recipeName>cake</recipeName>
   <recipeType>snack</recipeType>
   <recipeIngridients>
     <string>butter</string>
     <string>sugar</string>
   </recipeIngridients>
   </Recipe>  

Answer 1

I believe the way you are deserializing the xml is incorrect with BinarySerialization.ReadFromBinaryFile....

Assuming your xml is correct I would do something like this.

// read file
List<Recipe> recipes;
using (var reader = new StreamReader("recipe.xml"))
{
    XmlSerializer deserializer = new XmlSerializer(typeof(List<Recipe>),  
        new XmlRootAttribute("Recipe"));
    recipes = (List<Recipe>)deserializer.Deserialize(reader);
}

Answer 2

These are the changes I made. It's best to load the previous recipes, add to the list, then re-write the XML from scratch.

public class Recipe
{
    public string recipeName;
    public string recipeType;
    public List<string> recipeIngridients = new List<string>();

    public Recipe readOne(string name)
    {
        CookBook newCB = new CookBook();
        List<Recipe> allRecipies = newCB.readAll();
        foreach(Recipe oneRecipe in allRecipies)
        {
            if(oneRecipe.recipeName == name)
            {
                return oneRecipe;
            }
        }
        return newCB.defaultRecipe;
    }
}

public class RecipeList
{
    public List<Recipe> Recipes = new List<Recipe>();
}

public class CookBook
{
    public Recipe defaultRecipe; 
    public string path;

    public void Save(Recipe newRecipe) 
    {
        TextWriter writer = null;
        RecipeList recipeList = null;
        try
        {
            // See if recipes exists
            var serializer = new XmlSerializer(typeof(RecipeList));
            if (File.Exists(path)) // Load the recipe list if it exists
            {
                using (var fileStream = File.OpenRead(path))
                {
                    recipeList = (RecipeList)serializer.Deserialize(fileStream);
                }
            }
            else
            {
                recipeList = new RecipeList();
            }

            // Add recipe to the list
            recipeList.Recipes.Add(newRecipe);
            writer = new StreamWriter(path, append: false);
            serializer.Serialize(writer, recipeList);
        }
        finally
        {
            if (writer != null)
                writer.Close();
        }
    }

    public List<Recipe> readAll()
    { 
        RecipeList temp = null;
        var serializer = new XmlSerializer(typeof(RecipeList));
        try
        {
            using (var fileStream = File.OpenRead(path))
            {
                temp = (RecipeList)serializer.Deserialize(fileStream);
            }
            return temp.Recipes;
        }
        catch (Exception e)
        {
            string error = @"An exception occured: " + e;
            //Log theLog = new Log();
            //theLog.LogMessage(error);
            return new List<Recipe>();
        }
    }
}