oracle tomcat-jdbc pool connection always use same session

Question

I have a spring boot tomcat-jdbc configuration with:

        DataSource ds = new DataSource();

    ds.setDriverClassName("oracle.jdbc.OracleDriver");
    ds.setUrl("jdbc:oracle:thin:@10.101.7.16:1521:SIAMA");
    ds.setUsername("xxx");
    ds.setPassword("ccc");
    ds.setInitialSize(10);
    ds.setMaxActive(15);
    ds.setMaxIdle(10);
    ds.setMinIdle(5);

When i start tomcat i see in my database session 10 initial inactive session. The problem is when the users starts app always user the same connection in database. The other 9 never use.

This is my code:

package com.csi_ti.itaca.custom.general.server.service;

import org.apache.tomcat.jdbc.pool.DataSource;



public class GeneralBusinessServiceImpl implements GeneralBusinessService {

public Connection conn;
ConversionUtil convert = new ConversionUtil();

@Autowired
@Qualifier("plsqlDataSource")
private DataSource plsqlDataSource;

@PostConstruct
public void init() throws SQLException {
    System.out.println(">>>>> GeneralBusinessService Con 1");
    conn = plsqlDataSource.getConnection();
}

public Connection obtenerConexion() {
    System.out.println("Obtener conexion......................");
    try {
        if ( conn.isClosed()) {
            System.out.println(">>>>>>>>>>> Conexión cerrada");

            return conn = plsqlDataSource.getConnection();
        }
        else {
            System.out.println(">>>>>>>>>>> Conexión ABIERTA");
            conn.close();
            conn = null;
            System.out.println(">>>>>>>>>>> La cerramos");
            conn = plsqlDataSource.getConnection();
            System.out.println(">>>>>>>>>>> La volvemos a abrir " + conn.toString());
            return conn;



        }
    } catch (SQLException e) {
        // TODO Auto-generated catch block
        e.printStackTrace();
    }
    return conn;
}

public void ejecutarConsulta() {
    //System.out.println("Entramos a ejecutar consulta <<<<<<<<<<<<<<<<<<<*<*<*<*<*<*<*<*<*<*>*>*<*<" );
    //System.out.println("Antes de Pob ****: " + conn);
    System.out.println(">>>>> GeneralBusinessService Con 2");
    PAC_SHWEB_PROVEEDORES llamada = new PAC_SHWEB_PROVEEDORES(conn);
    try {
        llamada.ejecutaPAC_SHWEB_PROVEEDORES__F_LISTA_TELEFONOS_EXPEDIENTE(new BigDecimal("906000060"));
    } catch (Exception e) {
        // TODO Auto-generated catch block
        e.printStackTrace();
    }
    //System.out.println("Pob ****: " + llamada.toString());

}

private Generico0DTO getDTO(Object obj){

    System.out.println(">>>>> GeneralBusinessService Con 3");
    Generico0DTO dto = new Generico0DTO();
    List<Generico0.MapObject> listMapObjects= new ArrayList<Generico0.MapObject>();

    if (obj!=null){

        if (obj instanceof List<?>){
            for (Map m :(List<Map>)obj){
                Generico0.MapObject mapObject = new Generico0.MapObject();
                mapObject.setMap(m);
                listMapObjects.add(mapObject);
            }
        }else if (obj instanceof Map){

            Generico0.MapObject mapObject = new Generico0.MapObject();
            mapObject.setMap((Map)obj);
            listMapObjects.add(mapObject);

        }else if (obj instanceof BigDecimal){

            Generico0.MapObject mapObject = new Generico0.MapObject();
            Map map = new HashMap<String,BigDecimal>();
            map.put("RETURN",obj);
            mapObject.setMap(map);
            listMapObjects.add(mapObject);
        }           
    }
    dto.setMapObject(listMapObjects);
    return dto;
}

@Override
public Generico0 ejecutaPAC(String pac, String function, boolean tratarMensajes, Object... parameters) {
    System.out.println(">>>>> GeneralBusinessService Con 4");
    Map map;
    try {


        Class<?> clazz = Class.forName("com.csi_ti.itaca.custom.general.server.jdbc." + pac);
        Constructor<?> constructor =  clazz.getConstructor(Connection.class);
        Object pacInstance = constructor.newInstance(conn);

        String methodName = "ejecuta"+pac+"__"+function;

        ////System.out.println("LLamada pac: "+methodName);


        Class<?>[] parameterTypes = new Class<?>[parameters.length];
        Object[] parameterInput = new Object [parameters.length];

        for (int i = 0; i < parameters.length; i++) {
            if (parameters[i].getClass().equals(Integer.class)) {
                parameterTypes[i] = BigDecimal.class;
                parameterInput[i] = new BigDecimal((Integer) parameters[i]);
            } else {
                parameterTypes[i] = parameters[i].getClass();
                parameterInput[i] = parameters[i];
            }
        }

        Method method = clazz.getDeclaredMethod(methodName, parameterTypes);

        map = (Map) method.invoke(pacInstance, parameterInput);

        if(tratarMensajes){
            Object obj = Util.tratarRETURNyMENSAJES(map);
            return getDTO(obj);
        } else {
            return getDTO(map);
        }


    } catch (Exception e) {
        //System.out.println("Error_Service:"+e);

        return null;
    }
}

}

I need the pool to balance sessions for each request. Any help ?

Thank you.

Answer 1

Your @PostConstruct method is bad and wrong. Instead of having the Connection conn variable that you initialize in your post construct, get a connection from the datasource whenever you need to use one.

try(Connection con = plsqlDataSource.getConnection()) {
    // Do something with con
}

It's a lot simpler than what you've written too!

Your obtenerConexion() is unnecessary too. You are using a connection pool, you're not writing one.

You also shouldn't use org.apache.tomcat.jdbc.pool.DataSource directly, but rather javax.sql.DataSource .