Convert large httppostedfilebase to byte[]

Question

I want to convert httppostedfilebase type to byte[] type. I use this code :

    private static byte[] ConverToBytes(HttpPostedFileBase file)
    {
        int fileSizeInBytes = file.ContentLength; //134675091 (129MB)
        MemoryStream target = new MemoryStream();
        file.InputStream.CopyTo(target);//System.OutOfMemoryException
        byte[] data = target.ToArray();

        return data;
    }

When I use this code, I get the System.OutOfMemoryException.

any soulotion about it

Answer 1

Actually you may creating more than one copy of byte stream with MemoryStream , this is why OutOfMemoryException was thrown. Use BinaryReader instead:

private static byte[] ConvertToBytes(HttpPostedFileBase file)
{
    int fileSizeInBytes = file.ContentLength;
    byte[] data = null;
    using (var br = new BinaryReader(file.InputStream))
    {
        data = br.ReadBytes(fileSizeInBytes);
    }

    return data;
}

NB: I strongly suggests using statement wraps all instance creation which uses memory space and implements IDisposable such like MemoryStream does.

Similar issue:

Convert HttpPostedFileBase to byte[] array