Remove Tab Fragment from ViewPager and TabLayout Android

Question

I have an activity that hosts tablayout with viewpager and fragments. I have successfully setup the tablayout and viewpager with user-populated values from a local database like below code(trying to be brief, showing only one tab here) -

public void setUpTabs() {
   setUpViewPager(viewPager);
   tabLayout.setTabGravity(TabLayout.GRAVITY_FILL);
   tabLayout.setTabMode(TabLayout.MODE_SCROLLABLE);
   tabLayout.setupWithViewPager(viewPager);
}

private void setUpViewPager(ViewPager viewPager) {

  Customize customize = new Select()  
          .from(Customize.class)
          .where("tabName = ? ", Constants.NATURE)
          .executeSingle();
  if (customize != null) {
      String nature = customize.tabName;
      Log.d(TAG, "Nature Tab Name:\t" + nature);
  }

  pagerAdapter = new TabsPagerAdapter(getSupportFragmentManager());
  pagerAdapter.addTab(new Top30Fragment(), Constants.Top30); // default tab

  if (nature != null) {
      pagerAdapter.addTab(new NatureFragment(), Constants.NATURE); // dynamic tab from db
  }

  pagerAdapter.addTabAtLastPosition(new PrefsFragment(), Constants.PREFS);

  viewPager.setAdapter(pagerAdapter); 
  }

Customize is model class, I have used ActiveAndroid library for persistence. Here's my tabsadapter class code:

public class TabsPagerAdapter extends FragmentPagerAdapter {

private static final String TAG = TabsPagerAdapter.class.getSimpleName();
private List<Fragment> fragmentList = new ArrayList<>();
private List<String> titlesList = new ArrayList<>();

private ViewPager viewPager;
private TabLayout tabLayout;

public TabsPagerAdapter(FragmentManager fm) {
    super(fm);
}

@Override
public Fragment getItem(int position) {
    return fragmentList.get(position);
}

@Override
public int getCount() {
    return fragmentList.size();
}

public void addTab(Fragment fragment, String name){
     fragmentList.add(fragment);
     titlesList.add(name);
}

public void addTabAtLastPosition(Fragment fragment, String name){
     fragmentList.add(fragmentList.size(), fragment);
     titlesList.add(name);
}

public void removeTab(Fragment fragment, String name){ //Not working
     for (int i = 0; i < fragmentList.size(); i++){
         if (fragmentList.get(i).equals(fragment)){ // never enters/returns from this loop
              Log.d(TAG, "Fragment at position:\t" + i);
              fragmentList.remove(fragment);
              titlesList.remove(name);
           }
      }
 }

 @Nullable
 @Override
 public CharSequence getPageTitle(int position) {
     return titlesList.get(position);
 } 
 }

In my preferences fragment(also part of the tablayout), I have a recyclerview with checkboxes, case1:if checked, the tab is checked in db and only added to tablayout if not already there. case2:Otherwise if unchecked, means the tab is in layout and db and has to be removed from both.

I have started working on case 2 but I'm only able to delete values from db, the tab to be deleted is still present in tablayout. Here's my recyclerview adapter code to delete the tab:

public class PrefsAdapter extends RecyclerView.Adapter<PrefsCustomizeViewHolder> {

private static final String TAG = PrefsAdapter.class.getSimpleName();

private final Context context;
private List<Customize> itemsList;

private long id_nature, id_space, id_seasons, id_art, id_scifi, id_misc;
private Customize cust; // Model class for saving and retrieving tabs

private TabsPagerAdapter pagerAdapter;
private String nature, space, seasons, art, scifi, misc;
private String tabNature, tabSpace, tabSeasons, tabArt, tabScifi, tabMisc;

public PrefsAdapter(Context context, List<Customize> itemsList) {
    this.context = context;
    this.itemsList = itemsList;
    pagerAdapter = new TabsPagerAdapter(((AppCompatActivity)context).getSupportFragmentManager());
}

@Override
public PrefsCustomizeViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
    View view = LayoutInflater.from(parent.getContext()).inflate(R.layout.prefs_customize_items_layout, parent, false);
    return new PrefsCustomizeViewHolder(view);
}

@Override
public void onBindViewHolder(final PrefsCustomizeViewHolder viewholder, final int position) {
  final Customize customize = itemsList.get(position);

  Picasso.with(context)
          .load(customize.getIcon())
          .fit()
          .into(viewholder.prefsSelImg);

         // search db to find if checkbox is checked, i.e tab is present or not and update recyclerview
  switch (position) {
      case 0:
          cust = new Select()
                  .from(Customize.class)
                  .where("tabName = ? ", Constants.SPACE)
                  .executeSingle();
          if (cust != null) {
              space = cust.tabName;
              Log.d(TAG, "Space Tab From DB:\t" + space);
              id_space = cust.getId();
              Log.d(TAG, "Space Tab Id from DB:\t" + id_space);
              viewholder.prefsCheckBox.setChecked(true);
           } else {
              viewholder.prefsCheckBox.setVisibility(View.INVISIBLE);
              viewholder.prefsCheckBox.setChecked(false);
           }
           break;
   }

   viewholder.prefsSelImg.setOnClickListener(new View.OnClickListener() {
       @Override
       public void onClick(View view) {
          switch (position) {
              case 0:
                  if (viewholder.prefsCheckBox.isChecked()){
                      viewholder.prefsCheckBox.setChecked(false);

                      Customize.delete(Customize.class, id_space);
                      Log.d(TAG, "Deleted Space id:\t" + id_space); // prints right log detail
                      pagerAdapter.removeTab(new SpaceFragment(), Constants.SPACE);

                   } else {
                      viewholder.prefsCheckBox.setChecked(true);

                      customize.setTabId(UUID.randomUUID().toString());
                      customize.setTabName(Constants.NATURE);
                      customize.save();

                      pagerAdapter.addTab(new SpaceFragment(), Constants.SPACE);

                      viewholder.prefsCheckBox.setVisibility(View.VISIBLE);
                   }
                  break;
           }

        }
    });

}

@Override
public int getItemCount() {
    if (itemsList == null) {
       return 0;
    }
     return itemsList.size();
 }

}

The tabspagerAdapter.removeTab() never gets called even though I have initialized it in the constructor like below:

public PrefsAdapter(Context context, List<Customize> itemsList) {
this.context = context;
this.itemsList = itemsList;
pagerAdapter = new TabsPagerAdapter(((AppCompatActivity)context).getSupportFragmentManager());
} 

Can someone help me out with removing the fragment and also why the pagerAdapter.removeTab(fragment, title) method never gets called and how to update the tab layout. Thanks.

Answer 1

I have used the following code to successfully change the number of tabs (both add and remove). I found I had to remove them from both the pager adapter and the tab layout.

int cnp = mPagerAdapter.getCount();

// remove all tabs (or just the ones you need to remove) 
// from both the pager adapter and the tab layout
for(int i = cnp-1; i >= 0; --i) {
    mPagerAdapter.destroyItem(mViewPager, i, mPagerAdapter.getItem(i));
    mTabLayout.removeTabAt(i);
}

// add back in whatever tabs you need and update the pager adapter to be consistent
mTabLayout.addTab(mTabLayout.newTab().setText("Tab 0"),0);
mTabLayout.addTab(mTabLayout.newTab().setText("Tab 1"),1);
mPagerAdapter.setConfiguration(2); // my custom method to tell it which pages to show

mTabLayout.invalidate();
mPagerAdapter.notifyDataSetChanged();

Relevant class members:

ViewPager mViewPager;
TabLayout mTabLayout;
MyPagerAdapter mPagerAdapter; // extends FragmentPagerAdapter