Knex pool full on migration

Question

I'm trying to get started with knex.js and I can't get migrations to work. Knex works fine for my API calls. Here's my setup:

knexfile.js

const env = process.env;

module.exports = {
  client: 'mysql',
  connection: {
    host: env.DB_HOST,
    database: env.DB_NAME,
    user:     env.DB_USER,
    password: env.DB_PASSWORD,
    port: env.PORT
  },
  pool: {
    min: 0,
    max: 50
  },
  migrations: {
    directory: './db/migrations',
    tableName: 'knex_migrations'
  },
  seeds: {
    directory: './db/seeds'
  }
};

knex.js

const config = require('../knexfile.js');

module.exports = require('knex')(config);

events.js

const express = require('express');
const router = express.Router();
const knex = require('../../db/knex.js');

// GET api/events
router.get('/', (req, res) => {
    knex('events')
        .then(events => { res.send(events) }
        .catch(err => { console.log(err); })
});

module.exports = router;

and then I have a file in the migrations folder with:

exports.up = function(knex) {
  return knex.schema.createTable('users', function (t) {
    t.increments('id').primary()
    t.string('username').notNullable()
    t.string('password').notNullable()
    t.timestamps(false, true)
  }).then(() => { console.log('created users table') })
    .catch((err) => { throw err} )
    .finally(() => { knex.destroy() })
};

exports.down = function(knex) {
  return knex.schema.dropTableIfExists('users')
};

When I run knex migrate:latest I get TimeoutError: Knex: Timeout acquiring a connection. The pool is probably full. Are you missing a .transacting(trx) call? TimeoutError: Knex: Timeout acquiring a connection. The pool is probably full. Are you missing a .transacting(trx) call?

I know similar questions have been asked before, but I can't seem to find any that shed light on my particular situation. I've tried adding a knex.destroy() to the end of my GET request but that doesn't seem to help (it just makes the connection unusable if I add other request handlers below).

I did try checking the knex.client.pool in a finally clause at the end of the GET request. numUsed was 0, numFree was 1, numPendingAcquires and numPendingCreates were both 0. I do find it odd that numFree was only 1 given that my knexfile specifies max 50. Any advice greatly appreciated.

Answer 1

Following @technogeek1995's comment, the answer turned out to be adding require('dotenv').config({path: '../.env'}); to knexfile.js (in retrospect, this part seems obvious), and running the cli from the same directory. Hope this helps someone else.