Python Functions with multiple arguments

Question

I have written the following code

def createv(dsn,vname,benchdsn,benchvar):
    #global grp
    for t in range(len(dsn)):
        w=dsn[vname].iloc[t]
        #print(w)
        for index in range(len(benchdsn)):
            #print(index)
            z = benchdsn[benchvar].iloc[index]
            #print(z)
            if w <= z:
                grp = z
                print(grp)
                break     
            else:
                continue
    return grp

recent_sample['carvaluegrp2']= createv(recent_sample,'CarValue',df6,'carvalueU')

The issue is that for the newly created variable carvaluegrp2, all values are the same - which is the last value of CarValue from recent_sample. I tried to use map() and apply() functions, but I am getting syntax errors. All I want is to have appropriate value - which the function is returning for each record of CarValue - as a value in the variable carvaluegrp2.

Answer 1

You need to append your result to a running list like this:

def createv(dsn,vname,benchdsn,benchvar):
    result = []
    for t in range(len(dsn)):
        w=dsn[vname].iloc[t]
        #print(w)
        for index in range(len(benchdsn)):
            #print(index)
            z = benchdsn[benchvar].iloc[index]
            #print(z)
            if w <= z:
                grp = z
                print(grp)
                break     
            result.append(grp)
    return result

Also, you never need else: continue . It's the same as having the if statement without an else.