How to call outer function's return from inner function?

Question

I have such code:

function allValid() {
    $('input').each(function(index) {
        if(something) {
            return false; 
        }    
    });

    return true;
}

which always returns true as return false; affects anonymous inner function. Is there an easy way to call outer function's return?

PS. I am not looking for a workaround, just want to know the answer to original question. If the answer is "not possible" it is fine.

Answer 1

Yeah, store it in a local variable.

function allValid() {
  var allGood = true;
  $('input').each(function (index) {
    if (something) {
      allGood = false;
    }
  });

  return allGood;
}

Answer 2

You can also do this with filter:

var anyInvalid = $('input').filter(function(index) {
                   if(inValidCheck)
                     return true;
                 }).length;

This works because 0 is treated as false, but it actually gives you the number of invalid, which you could use this to display "You have 3 invalid entries" or something if you wanted.

Answer 3

If you want to do this efficiently, I think this is the best way:

function allValid() {
  elements = $('input')
  for (i = 0; i < elements.length; i++) { invalidityCheck(elements[i]) && return false; }
  return true;
}

Edit: Although a more JavaScript-y version would probably use exceptions:

function allValid() {
  try
    $('input').each(function(index)) {
      if (something) { throw 'something happened!'; }
    });
  catch (e) {
    if (e == 'something happened!') {
      return false;
    } else {
      throw e;
    }
  }
  return true;
}

Answer 4

You could also use Array.prototype.some which iterates until finding an element that matches the criteria.

function allValid() {
    var inputs = $('input');
    if(inputs.toArray().some(function(input){
        if(something)
            return true;
    })) {
        return false;
    } else {
        return true;
    }
}