Why is this code leaking so much?

Question

Can someone please tell me why this code is leaking? Instruments is showing several leaks and i cant figure out why and i have gone through the code several times?

Basically the first method initializes a bunch of Thumbnail classes from a property list and then builds an array which is used as a tableviews datasource. The second method updates the tableviews datasource when a new section is chosen:

Here is the initialization and dealloc calls:

NSMutableArray *thumbnailsDatasource;   
NSMutableDictionary *sectionsDictionary;

@property (nonatomic, retain) NSMutableArray *thumbnailsDatasource;
@property (nonatomic, retain) NSMutableDictionary *sectionsDictionary;
@synthesize thumbnailsDatasource;
@synthesize sectionsDictionary;

[thumbnailsDatasource release], thumbnailsDatasource = nil; 
[sectionsDictionary release], sectionsDictionary = nil;

And here are the two methods causing the leaks:

- (void)initThumbnails
{
    // init sections dictionary
    NSMutableDictionary *sectionsDict = [[NSMutableDictionary alloc] init];

    // read the cover data from the plist
    NSString *thePath = [[NSBundle mainBundle]  pathForResource:kThumbnailPlistName ofType:@"plist"];
    NSArray *thumbsArray = [[NSArray alloc] initWithContentsOfFile:thePath];

    // iterate over the values in the dictionary
    for (NSDictionary *currentThumb in thumbsArray)
    {
        Thumbnail *newThumb = [[Thumbnail alloc] initWithName:[currentThumb objectForKey:kThumbnailName]
                                                      fileURL:[currentThumb objectForKey:kThumbnailFileURL]
                                                     imageURL:[currentThumb objectForKey:kThumbnailImageURL]
                                                      section:[currentThumb objectForKey:kThumbnailSection]
                                                   pageNumber:[(NSNumber*)[currentThumb objectForKey:kThumbnailPageNumber] integerValue]];

        // check if we already have an array in sectionsDictionary for that section
        if ([sectionsDict objectForKey:newThumb.section]) 
        {       
            NSMutableArray *currentSectionArray = [sectionsDict objectForKey:newThumb.section];
            [currentSectionArray addObject:newThumb];
        }
        else 
        {
            NSMutableArray *newSectionArray = [[NSMutableArray alloc] init];
            [newSectionArray addObject:newThumb];

            [sectionsDict setObject:newSectionArray forKey:newThumb.section];
            [newSectionArray release], newSectionArray = nil;
        }       
        [newThumb release], newThumb = nil;
    }

    [thumbsArray release], thumbsArray = nil;

    self.sectionsDictionary = sectionsDict;
    [sectionsDict release], sectionsDict = nil;


    NSMutableArray *tempThumbsArray = [[NSMutableArray alloc] init];

    // set datasource to All sections in dictionary
    NSArray *allValuesArray = [self.sectionsDictionary allValues];

    for (NSMutableArray *currentSection in allValuesArray)
    {
        [tempThumbsArray addObjectsFromArray:currentSection];
    }

    // sort array by pageNumber asc
    [tempThumbsArray sortUsingSelector:@selector(comparePageNumberAsc:)];
    self.thumbnailsDatasource = tempThumbsArray;

    [tempThumbsArray release], tempThumbsArray = nil;

}

- (void)changeDatasourceToSection:(NSString*)section
{

    if ([section isEqualToString:kAllSectionsName]) {

        NSMutableArray *tempThumbsArray = [[NSMutableArray alloc] init];

        // set datasource to All sections in dictionary
        NSArray *allValuesArray = [self.sectionsDictionary allValues];

        for (NSMutableArray *currentSection in allValuesArray)
        {
            [tempThumbsArray addObjectsFromArray:currentSection];
        }

        // sort array by pageNumber asc
        [tempThumbsArray sortUsingSelector:@selector(comparePageNumberAsc:)];
        self.thumbnailsDatasource = tempThumbsArray;

    }
    else {
        NSMutableArray *newDatasource = (NSMutableArray*)[self.sectionsDictionary objectForKey:section];
        [newDatasource sortUsingSelector:@selector(comparePageNumberAsc:)];
        self.thumbnailsDatasource = newDatasource;
    }
}

Answer 1

在tempThumbsArray此行之后，不会释放tempThumbsArray变量changeDatasourceToSection:

NSMutableArray *tempThumbsArray = [[NSMutableArray alloc] init];