C++ : List iterator not incrementable

Question

Getting this error while trying to erase the last element of a list. I debugged the code and was able to figure out what causes it and where, here's my code:

    for(Drop_List_t::iterator i = Drop_System.begin(); i != Drop_System.end() && !Drop_System_Disable; /**/)
{
    if(Player->BoundingBox.Intersect(&(*i)->BoundingBox))
    {
        i = Drop_System.erase(i);
    }

    ++i; //List iterator crashes here if last entry was deleted
}

I can't figure out what I'm doing wrong... Any suggestions?

Answer 1

Your algorithm is flawed because you did not understood what erase returned.

When you use erase , it removes the element pointing to by the iterator, and returns an iterator to the next element.

If you wish to iterate over all elements of a list, it means that whenever erase was used you should not further increment it.

This is the normal code you should have gotten:

if (Player->BoundingBox.Intersect(i->BoundingBox)) {
  i = Drop_System.erase(i);
}
else {
  ++i; 
}

And this neatly solves the issue you are encountering! Because when you erase the last element, erase will return the same iterator as end , that is an iterator pointing one-past-the-last element. This iterator shall never be incremented (it may be decremented if the list is not empty).

Answer 2

You need to put ++i in an else clause. The erase function returns the next valid iterator- and you are then incrementing over it, ensuring that you do not iterate over every element. You should only increment it in the case in which you chose not to erase.

Answer 3

You want:

if(Player->BoundingBox.Intersect(&(*i)->BoundingBox))
{
    i = Drop_System.erase(i);
}
else {
    ++i; 
}