简体   繁体   中英

Entity Framework, why is my where being ignored?

Regarding the query below, why is my conditional where being ingored?

(Note: the commented out sql statement is what I tried to duplicate in this linq query.)

public static List<Sys.Entities.Hms206> Hms206Get( DateTime startDate, DateTime endDate, string courseNumber, bool sOnly ) {
    //select distinct
    //    p.DEPTID [Rc],
    //    p.NAME [EmployeeName],
    //    p.EMPLID [EmployeeId],
    //    x.XLATSHORTNAME [Ran]
    //from 
    //    tablep p
    //    inner join tablex x on p.CM_RAN = x.FIELDVALUE
    //    inner join tablet t on p.EMPLID = t.EMPLID
    //where
    //    p.DEPTID not like '%R'
    //    and p.EMPL_STATUS in('A','L','P','S','W')
    //    and t.COURSE_END_DT between '7/1/1960' and '12/27/2012' 
    //    and t.COURSE = 'C00005' 
    //    and t.ATTENDANCE = 'C' 
    //    and x.FIELDNAME = 'CM_RAN'

    //    and p.CM_IND = 'S' 
    //    --and p.CM_IND in ('S','C') -- all
    //order by 
    //    p.DEPTID, p.NAME
    string[] stats = new string[]{"A","L","P","S","W"};
    using ( var context = new Sys.EntityModels.LCEntities() ) {
        var query = ( from p in context.PsCmSummaries
                        join x in context.TableX on p.CM_RAN equals x.FIELDVALUE
                        join t in context.TableT on p.EMPLID equals t.EMPLID
                        where !p.DEPTID.EndsWith( "R" )
                        && stats.Contains( p.EMPL_STATUS )
                        && t.COURSE_END_DT >= startDate && t.COURSE_END_DT <= endDate
                        && t.COURSE == courseNumber
                        && t.ATTENDANCE == "C"
                        && x.FIELDNAME == "CM_Ran"
                        select new {
                            p.DEPTID,
                            p.NAME,
                            p.EMPLID,
                            x.XLATSHORTNAME,
                            p.CM_IND
                        } );
       // this conditional where is not being applied
       if ( sOnly ) {
            query.Where( x => x.CM_IND == "S" );
        }
        else {
            query.Where( x => x.CM_IND == "S" || x.CM_IND == "C" );
        }

        return query.Distinct().OrderBy( x => x.DEPTID ).ThenBy( x => x.NAME )
            .Select( 
                x => new Sys.Entities.Hms206 { 
                    Rc = x.DEPTID, EmployeeName = x.NAME, EmployeeId = x.EMPLID, 
            Rank = x.XLATSHORTNAME, S_Indicator = x.CM_IND 
            })
            .ToList();
    }
}

You can try this to replace your conditon:

if ( sOnly ) {
    query.Where( x => x.CM_IND == "S" );
}
else {
    query.Where( x => x.CM_IND == "S" || x.CM_IND == "C" );
}

With answer below :

query = sOnly ? query.Where(x => x.CM_IND == "S")
              : query.Where(x => x.CM_IND == "S" || x.CM_IND == "C");

You're calling Where but completely ignoring the return value - which makes the call useless. You want something like:

if (sOnly) {
    query = query.Where(x => x.CM_IND == "S");
}
else {
    query = query.Where(x => x.CM_IND == "S" || x.CM_IND == "C");
}

LINQ calls such as Where , Select etc don't modifying the existing query - they return a new query by composing the previous query with the new aspect.

The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.

 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM