How to change the flow of execution and function call in this Google Apps Script?

Question

I have a main function generatePersonDatasheet(theses) and I have a handler function submit(e) (the handler is in other function called showList() ). In the main function, I can call the handler function this way:

  if (theses == 1){
    Logger.log("going to showList() ");
    return showList();

If I drop de return in the line return showList(); the UI of showList() opens and closes at a fraction of second, not allowing the user choose the items. If I put this return , after the handler function submit(e) is closed, the code in my main function doesn't run the next line after the if block:

  if (theses == 1){
    Logger.log("going to showList() ");
    return showList();
  }     
  showURL(docName, link); //  Shows document name and link in UI

How could I fix that? How could I got the main function to runs its lines after the if (theses == 1) block? I didn't want to repeat the code in the handler function because it's bigger than the line showURL(docName, link); in the above sample.

This is the called functions:

 var fact_list = [ ["Kennedy Inauguration", "politics", "tZwnNdFNkNklYc3pVUzZINUV4eUtWVWFSVEf"], ["Pericles’ Funeral Oration", "politics", "sdgrewaNkNklYc3pVUzZINUV4eUtW345ufaZ"], ["The Pleasure of Books", "culture", "1234rFszdgrfYc3pVUzZINUV4eU43usacd"], ["I Am The First Accused (Nelson Mandela)", "law", "34rsgadOsidjSZIswjadi95uydnfklsdks"] ];

function showList() {
    Logger.log("running showList "); 
    var mydoc = SpreadsheetApp.getActiveSpreadsheet();
    var app = UiApp.createApplication();
    var panel = app.createVerticalPanel().setId('panel');
    // Store the number of items in the array (fact_list)
  Logger.log("fact_list.length " + fact_list.length);
    panel.add(app.createHidden('checkbox_total', fact_list.length));
    // add 1 checkbox + 1 hidden field per item 
    for(var i = 0; i < fact_list.length; i++){
      Logger.log("checkbox_isChecked_"+i + " = " + fact_list[i][0]);
      Logger.log("checkbox_value_"+i + " = " + fact_list[i]);
      var checkbox = app.createCheckBox().setName('checkbox_isChecked_'+i).setText(fact_list[i][0]);
      var hidden = app.createHidden('checkbox_value_'+i, fact_list[i]);
      panel.add(checkbox).add(hidden);
    }
    var handler = app.createServerHandler('submit').addCallbackElement(panel);
    panel.add(app.createButton('Submit', handler));
    app.add(panel);
    mydoc.show(app);
}

function submit(e){
  Logger.log("running submit(e)"); 
  var numberOfItems = e.parameter.checkbox_total;
  var itemsSelected = [];
  // for each item, if it is checked / selected, add it to itemsSelected
  for(var i = 0; i < numberOfItems; i++){
    if(e.parameter['checkbox_isChecked_'+i] == 'true'){
      itemsSelected.push(e.parameter['checkbox_value_'+i]);
    }
  }
  var app = UiApp.getActiveApplication();

  Logger.log("itemsSelected = " + itemsSelected);

  ScriptProperties.setProperties({'theses': itemsSelected}, true); 


  var thesesArrays = ScriptProperties.getProperty('theses');
  Logger.log("thesesArrays = " + thesesArrays);// to see targetDoc's content
  for (var i = 0; i < thesesArrays.lenght; i++){
       var thesesId = ScriptProperties.getProperty('theses')[i][2];
       var thesesType = ScriptProperties.getProperty('theses')[i][1];
       importTheses(target, thesesId, thesesType);
} 

  app.close();
  return app;
}


function importTheses(targetDocId, thesesId, thesesType) { // adapted from Serge insas
  Logger.log("running importTheses() ");
  var targetDoc = DocumentApp.openById(targetDocId);
  var targetDocParagraphs = targetDoc.getParagraphs();
  var targetDocElements = targetDocParagraphs.getNumChildren();

  var thesesDoc = DocumentApp.openById(thesesId);
  var thesesParagraphs = thesesDoc.getParagraphs();
  var thesesElements = thesesDoc.getNumChildren();

  var eltargetDoc=[];
  var elTheses=[];

  for( var j = 0; j < targetDocElements; ++j ) {
       var targetDocElement = targetDoc.getChild(j);
//     Logger.log(j + " : " + type);// to see targetDoc's content
       eltargetDoc[j]=targetDocElement.getText();
       if(el[j]== thesesType){
           for( var k = 0; k < thesesParagraphs-1; ++k ) {
               var thesesElement = thesesDoc.getChild(k);
               elTheses[k] = thesesDoc.getText();
               targetDoc.insertParagraph(j, elTheses[k]);
         }
      }
   }
}

Answer 1

Please have a look at this worflow, wouldn't it be more easy ?

(check the log to confirm the last function was called)

note : I didn't use scriptProperties as it was not necessary anymore since factList is a global variable in your example... and I simplified the importTheses function for this test since I had no docs to use ;-)

var fact_list = [["Kennedy Inauguration", "politics", "tZwnNdFNkNklYc3pVUzZINUV4eUtWVWFSVEf"], ["Pericles Funeral Oration", "politics", "sdgrewaNkNklYc3pVUzZINUV4eUtW345ufaZ"], ["The Pleasure of Books", "culture", "1234rFszdgrfYc3pVUzZINUV4eU43usacd"], ["I Am The First Accused (Nelson Mandela)", "law", "34rsgadOsidjSZIswjadi95uydnfklsdks"]];

function showList() {
    var mydoc = SpreadsheetApp.getActiveSpreadsheet();
    var app = UiApp.createApplication();
    var panel = app.createVerticalPanel().setId('panel');
    // Store the number of items in the array (fact_list)
    panel.add(app.createHidden('checkbox_total', fact_list.length));
    // add 1 checkbox + 1 hidden field per item 
    for(var i = 0; i < fact_list.length; i++){
      var checkbox = app.createCheckBox().setName('checkbox_isChecked_'+i).setText(fact_list[i][0]);
      panel.add(checkbox);
    }
    var handler = app.createServerHandler('submit').addCallbackElement(panel);
    panel.add(app.createButton('Submit', handler));
    app.add(panel);
    mydoc.show(app);
}

function submit(e){
  var numberOfItems = Number(e.parameter.checkbox_total);
  var thesesArrays = [];
  for(var i = 0; i < numberOfItems; i++){
    if(e.parameter['checkbox_isChecked_'+i] == 'true'){
      thesesArrays.push(fact_list[i]);
    }
  }
  Logger.log(thesesArrays);
  var target = 'target doc';
  for (var i = 0; i < thesesArrays.length; i++){
    var thesesId = thesesArrays[i][2];
    var thesesType = thesesArrays[i][1];
    importTheses(target, thesesId, thesesType);
  }
  //  showURL(docName, link); /
  return UiApp.getActiveApplication().close();
}


function importTheses(targetDocId, thesesId, thesesType) { // adapted from Serge insas
  Logger.log(targetDocId+'  '+thesesId+'  '+thesesType);
}