JavaScript proper way to handle null in JSON object

Question

Here is the code :

for (i = 0; i < data.RecruitingGroups.length; i++) {
        data.RecruitingGroups[i].id = i;

        if (data.RecruitingGroups[i].Rule.Rules != null) {
            for (j = 0; j < data.RecruitingGroups[i].Rule.Rules.length; i++) {
                data.RecruitingGroups[i].Rule.Rules[j].id = j;
            }    
        } 
    }

Problem is that sometimes RecruitingGroups[].Rule is null. So I tried to verify it was not null before continuing and running the next for loop, but it still throws the error:

Uncaught TypeError: Cannot read property 'Rules' of null

How can i bypass this error.

Answer 1

You're testing if Rule.Rules is null . That's not the problem; Rule itself is null , as evidenced by the error message. You need to test both Rule and Rule.Rules if either can be null.

Try

if (data.RecruitingGroups[i].Rule && data.RecruitingGroups[i].Rule.Rules) {

Answer 2

your second loop needs to increment j++ not i++ . =)

Answer 3

 if (data.RecruitingGroups[i].Rule && data.RecruitingGroups[i].Rule.Rules) {
        for (j = 0; j < data.RecruitingGroups[i].Rule.Rules.length; i++) {
            data.RecruitingGroups[i].Rule.Rules[j].id = j;
        }    
    }