C# Oracle database connection

Question

I am trying to connect to an oracle database using C#.

Here is my code:

      OracleConnection conn = new OracleConnection(); // C#
           conn.ConnectionString = oradb;
        conn.Open();
        string sql = " select department_name from departments where department_id = 10"; // C#
        OracleCommand cmd = new OracleCommand();
        cmd.CommandText = sql;
        cmd.Connection = conn;
        cmd.CommandType = CommandType.Text; ///this is the line that gives the error

What is the proper way to set the command type? Thank you.

Answer 1

Using Store Procedure :

using (OracleConnection conn = new OracleConnection( oradb ))
{
      conn.Open();
      OracleCommand cmd = new OracleCommand("StoreProcedureName", con);
      cmd.CommandType = CommandType.StoredProcedure;   

      //specify command parameters 
      //and Direction

      using(OracleDataReader reader = cmd.ExecuteReader())
      {
          while (reader.Read())
          {
             //string s = reader.GetInt32(0) + ", " + reader.GetInt32(1);
          }
      }                   
}

CommandType.Text : (not mandatory to specify CommandType).

using (OracleConnection conn = new OracleConnection( oradb ))
{
      string sql = @"SELECT department_name FROM departments 
                     WHERE department_id = @department_id";
      conn.Open();
      OracleCommand cmd = new OracleCommand(sql, conn);

      //specify command parameters
      cmd.Parameters.Add(new OracleParameter("@department_id", 10));

      using(OracleDataReader reader = cmd.ExecuteReader())
      {
          while (reader.Read())
          {
             //string s = reader.GetString(0);
          }
      }                   
}

Answer 2

Make sure you toss each of these pieces in a using() statement, ie

using( OracleConnection conn = new OracleConnection( oradb ) )
{
    conn.Open();

    using( OracleCommand cmd = new OracleCommand( "sql here", conn ) )
    {
        //cmd.Execute(); cmd.ExecuteNonQuery();
    }
}