Rollback not working in jdbc spring programatic transaction

Question

Im unable to get a rollback working in my spring (3.0.5) jdbc application, running on Oracle 11.2

When I throw NoClassesException in the Controller below the row inserted by updatedB() remains in the dB. I think this is because autoCommit is on (by default) in my dataSource so the commit has already happened and the rollback obviously doesn't work, but I thought the Spring DataSourceTransactionManager handled all this and enforced the rollback?

Interestingly, when i turn autoCommit off in my dataSource ie comment in the :

"defaultAutoCommit" value="false" 

and call the commit explicity myself ie comment in:

this.jdbcTemplate.getDataSource().getConnection().commit();

nothing happens ie the row is not commited at all,so it looks like i've done something stupid. If someone could please point out this mistake I would be very gratefull

My code is :

public static void main(String[] args) {

        String [] configList ={"database.xml","spring.xml"};

        ApplicationContext ctx = new ClassPathXmlApplicationContext(configList);
        cont = (Controller)ctx.getBean("controller");
        cont.transactionTest();
}

// Controller , called from Main()

public class Controller {

    private JdbcTemplate jdbcTemplate;


    public void transactionTest()
    {       
        int retCode=0;


        try {
            retCode = updatedB("param1","param2");
            //this.jdbcTemplate.getDataSource().getConnection().commit();
            throw new NoClassesException(); 
        }catch (NoClassesException e){
            System.out.println(e.getMessage() + "2 patents ");
        }
    }

    public int updatedB(String param1,String param2 ) 
    {
        int stat = 0;

        stat = this.jdbcTemplate.update("INSERT INTO myTable"
                                + "(param1,param2)"
                                + " VALUES(?,?)"  , 
                new Object[] { param1,param2});

        return stat;
    }

    public JdbcTemplate getJdbcTemplate() {
        return jdbcTemplate;
    }

    public void setJdbcTemplate(JdbcTemplate jdbcTemplate) {
        this.jdbcTemplate = jdbcTemplate;
    }
}

public class NoClassesException extends RuntimeException  {

    public NoClassesException() {
        super("Rolled back ");
    }
}

and my spring.xml file is:

<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:tx="http://www.springframework.org/schema/tx"
    xmlns:aop="http://www.springframework.org/schema/aop"
    xsi:schemaLocation="http://www.springframework.org/schema/beans 
    http://www.springframework.org/schema/beans/spring-beans.xsd
    http://www.springframework.org/schema/aop
    http://www.springframework.org/schema/aop/spring-aop-2.0.xsd
    http://www.springframework.org/schema/tx 
    http://www.springframework.org/schema/tx/spring-tx-2.0.xsd">


    <bean id="controller" class="Controller">
        <property name="jdbcTemplate" ref="jdbcTemplate" />
    </bean>


    <bean id="txManager"
        class="org.springframework.jdbc.datasource.DataSourceTransactionManager">
        <property name="dataSource" ref="dataSource" />
    </bean>

    <tx:advice id="txAdvice" transaction-manager="txManager">
        <tx:attributes>
            <tx:method name="transaction*" propagation="REQUIRED" rollback-for="NoClassesException" />
            <tx:method name="update*" propagation="SUPPORTS" />
            <tx:method name="*" propagation="SUPPORTS" read-only="true" />
        </tx:attributes>
    </tx:advice>



    <aop:config>    
        <aop:pointcut id="myMethods" expression="execution(* *..Controller.*(..))" />
        <aop:advisor advice-ref="txAdvice" pointcut-ref="myMethods" />
    </aop:config>



    <bean id="jdbcTemplate" class="org.springframework.jdbc.core.JdbcTemplate">
        <property name="dataSource" ref="dataSource" />
    </bean>

</beans>

and my database.xml file is:

<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:tx="http://www.springframework.org/schema/tx"
    xmlns:aop="http://www.springframework.org/schema/aop"
    xsi:schemaLocation="http://www.springframework.org/schema/beans 
    http://www.springframework.org/schema/beans/spring-beans.xsd
    http://www.springframework.org/schema/aop
    http://www.springframework.org/schema/aop/spring-aop-2.0.xsd
    http://www.springframework.org/schema/tx 
    http://www.springframework.org/schema/tx/spring-tx-2.0.xsd">



    <bean id="dataConfigPropertyConfigurer"
        class="org.springframework.beans.factory.config.PropertyPlaceholderConfigurer">
        <property name="searchSystemEnvironment" value="true" />
    </bean>

    <bean id="dataSource" class="org.apache.commons.dbcp.BasicDataSource" destroy-method="close">
        <property name="driverClassName" value="oracle.jdbc.driver.OracleDriver" />
        <property name="initialSize" value="2" />
        <property name="maxActive" value="2" />

        <property name="url" value="my connection details" />
        <property name="username" value="xxx" />
        <property name="password" value="xxx" />
        <!-- <property name="defaultAutoCommit" value="false" /> -->
    </bean>

</beans>

Answer 1

Your code should be updated such as

 public void transactionTest()
    {       
        int retCode=0;

            retCode = updatedB("param1","param2");
            //this.jdbcTemplate.getDataSource().getConnection().commit();
            throw new NoClassesException(); 

    }

    public int updatedB(String param1,String param2 ) 
    {
        int stat = 0;

        stat = this.jdbcTemplate.update("INSERT INTO myTable"
                                + "(param1,param2)"
                                + " VALUES(?,?)"  , 
                new Object[] { param1,param2});

        return stat;
    }

    public JdbcTemplate getJdbcTemplate() {
        return jdbcTemplate;
    }

    public void setJdbcTemplate(JdbcTemplate jdbcTemplate) {
        this.jdbcTemplate = jdbcTemplate;
    }
}