Display chart in JavaFX

Question

I tried to rewrite and simplify the oracle tutorial for charts so, that you have a controller class and you work with fxml. For some reason it is not working.

Here is my code: Main class:

public class BarChartSample extends Application {

    Stage primaryStage;

    public void start(Stage primaryStage) {
        this.primaryStage = primaryStage;
        primaryStage.setTitle("Bar Chart Sample");

        showPage();
    }

    public void showPage(){
        try {
            FXMLLoader loader = new FXMLLoader();
        loader.setLocation(BarChartSample.class.getResource("ChartPage.fxml"));
            AnchorPane pane = loader.load();

            Scene scene  = new Scene(pane);
            primaryStage.setScene(scene);
            primaryStage.show();
        } catch (Exception e) {
            e.printStackTrace();
        }
    }

    public static void main(String[] args) {
        launch(args);
    }
}

Controller:

public class Controller {
    final static String performance = "Performance:";

    @FXML
    NumberAxis xAxis = new NumberAxis();
    @FXML
    CategoryAxis yAxis = new CategoryAxis();

    @FXML
    BarChart<Number,String> bc;

    public void initialize(){
        xAxis.setLabel("Percent");  
        xAxis.setTickLabelRotation(90);
        yAxis.setLabel("Performance");

        bc = new BarChart<Number,String>(xAxis,yAxis);

        XYChart.Series series1 = new XYChart.Series();     
        series1.getData().add(new XYChart.Data(80, performance));
        bc.getData().add(series1);
    }
}

FXML:

<?xml version="1.0" encoding="UTF-8"?>

<?import javafx.scene.control.*?>
<?import javafx.scene.chart.*?>
<?import java.lang.*?>
<?import javafx.scene.layout.*?>
<?import javafx.scene.layout.AnchorPane?>

<AnchorPane prefHeight="393.0" prefWidth="419.0" xmlns="http://javafx.com/javafx/8" xmlns:fx="http://javafx.com/fxml/1" fx:controller="Controller">
   <children>
      <BarChart fx:id="bc" layoutX="-40.0" layoutY="-3.0" prefHeight="205.0" prefWidth="409.0" AnchorPane.bottomAnchor="5.0" AnchorPane.leftAnchor="5.0" AnchorPane.rightAnchor="5.0">
        <xAxis>
          <CategoryAxis fx:id="yAxis" side="BOTTOM" />
        </xAxis>
        <yAxis>
          <NumberAxis side="LEFT" fx:id="xAxis" />
        </yAxis>
      </BarChart>
     <TextArea layoutX="103.0" layoutY="14.0" maxHeight="100.0" prefHeight="200.0" prefWidth="200.0" AnchorPane.leftAnchor="21.0"AnchorPane.rightAnchor="21.0" AnchorPane.topAnchor="5.0" />
        </children>
      </AnchorPane>

It won't display the chart properly, it is just drawing a few lines. Why? Thank you!

Answer 1

Remove this line from the initialize()

bc = new BarChart<Number,String>(xAxis,yAxis);

You are not supposed to re-initialize any controls which have already been defined in the FXML and have been integrated in the controller via @FXML annotation.

You also need to replace the following lines for the said reasons

@FXML
NumberAxis xAxis = new NumberAxis();
@FXML
CategoryAxis yAxis = new CategoryAxis();

with

@FXML
NumberAxis xAxis;
@FXML
CategoryAxis yAxis;

Again, you need to define the BarChart correctly. In the FXML, you have declared the xAxis to be a CategoryAxis and yAxis to be a NumberAxis . But in the controller you have defined a BarChart<Number,String> .

public class Controller {
    final static String performance = "Performance:";

    @FXML
    NumberAxis xAxis;
    @FXML
    CategoryAxis yAxis;

    @FXML
    BarChart<String, Number> bc;

    public void initialize(){
        xAxis.setLabel("Percent");
        xAxis.setTickLabelRotation(90);
        yAxis.setLabel("Performance");

        XYChart.Series<String, Number> series1 = new XYChart.Series();
        series1.getData().add(new XYChart.Data( performance, 80));
        bc.getData().add(series1);
    }
}