JPA Generic DAO

Question

I'm trying to implement a Generic DAO, using JPA, but I get a problem with this method:

public List<T> findAllByProperties( Map<String, Object> properties )
{
    CriteriaQuery<T> queryByProperties = createQueryByProperties( properties );
    TypedQuery<T> query = em.createQuery( queryByProperties );
    return query.getResultList(); //(<== this line triggers the error)
}

private CriteriaQuery<T> createQueryByProperties( Map<String, Object> properties )
{
    CriteriaBuilder cb = em.getCriteriaBuilder();
    CriteriaQuery<T> cq = cb.createQuery( entityClass );
    Root<T> root = cq.from( entityClass );
    Set<Entry<String, Object>> entrySet = properties.entrySet();
    List<Predicate> predicateList = new ArrayList<Predicate>();
    for ( Entry<String, Object> entry : entrySet )
    {
        String key = entry.getKey();
        Object value = entry.getValue();
        Predicate equal = cb.equal( root.get( key ), value );
        predicateList.add( equal );
    }
    cq = cq.where( cb.and( predicateList.toArray( new Predicate[ predicateList.size() ] ) ) );
    return cq;
}

Query seems to be fine when I do:

System.out.println( cq.toString() );

But I get this stacktrace:

Caused by: javax.ejb.EJBException: See nested exception; nested exception is: <openjpa-2.0.0-r422266:935683 nonfatal user error> org.apache.openjpa.persistence.ArgumentException: The specified parameter of type "class [Ljava.lang.Object;" is not a valid query parameter.
    Caused by: <openjpa-2.0.0-r422266:935683 nonfatal user error> org.apache.openjpa.persistence.ArgumentException: The specified parameter of type "class [Ljava.lang.Object;" is not a valid query parameter.
    at org.apache.openjpa.jdbc.sql.DBDictionary.setUnknown(DBDictionary.java:1418)
    at org.apache.openjpa.jdbc.sql.SQLBuffer.setParameters(SQLBuffer.java:644)
    at org.apache.openjpa.jdbc.sql.SQLBuffer.prepareStatement(SQLBuffer.java:553)
    at org.apache.openjpa.jdbc.sql.SQLBuffer.prepareStatement(SQLBuffer.java:529)
    at org.apache.openjpa.jdbc.sql.SelectImpl.prepareStatement(SelectImpl.java:451)
    at org.apache.openjpa.jdbc.sql.SelectImpl.execute(SelectImpl.java:392)
    at com.ibm.ws.persistence.jdbc.sql.SelectImpl.execute(SelectImpl.java:80)
    at org.apache.openjpa.jdbc.sql.SelectImpl.execute(SelectImpl.java:363)
    at org.apache.openjpa.jdbc.sql.LogicalUnion$UnionSelect.execute(LogicalUnion.java:427)
    at org.apache.openjpa.jdbc.sql.LogicalUnion.execute(LogicalUnion.java:230)
    at org.apache.openjpa.jdbc.sql.LogicalUnion.execute(LogicalUnion.java:220)
    at org.apache.openjpa.jdbc.kernel.SelectResultObjectProvider.open(SelectResultObjectProvider.java:94)
    at org.apache.openjpa.kernel.QueryImpl$PackingResultObjectProvider.open(QueryImpl.java:2068)
    at org.apache.openjpa.lib.rop.EagerResultList.<init>(EagerResultList.java:34)
    at org.apache.openjpa.kernel.QueryImpl.toResult(QueryImpl.java:1246)
    at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:1005)
    at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:861)
    at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:792)
    at org.apache.openjpa.kernel.DelegatingQuery.execute(DelegatingQuery.java:542)
    at org.apache.openjpa.persistence.QueryImpl.execute(QueryImpl.java:288)
    at org.apache.openjpa.persistence.QueryImpl.getResultList(QueryImpl.java:302)
    at cl.site.project.ejb.util.dao.GenericDAO.findAllByProperties(GenericDAO.java:145)

I hope anyone can help me.

Answer 1

I found a workaround. See comments.

public List<T> findAllByProperties( Map<String, Object> properties )
{
    CriteriaQuery<T> queryByProperties = createQueryByProperties( properties );
    TypedQuery<T> query = em.createQuery( queryByProperties );
    // ADDING THIS
    Set<String> keySet = properties.keySet();
    for ( String key : keySet )
    {
        Object value = properties.get( key );
        query.setParameter( key, value );
    }
    //  
    return query.getResultList();
}

private CriteriaQuery<T> createQueryByProperties( Map<String, Object> properties )
{
    CriteriaBuilder cb = em.getCriteriaBuilder();
    CriteriaQuery<T> cq = cb.createQuery( entityClass );
    Root<T> root = cq.from( entityClass );
    Set<Entry<String, Object>> entrySet = properties.entrySet();
    List<Predicate> predicateList = new ArrayList<Predicate>();
    for ( Entry<String, Object> entry : entrySet )
    {
        String key = entry.getKey();
        Object value = entry.getValue();
        ParameterExpression<?> val = cb.parameter( value.getClass(), key ); // <-- Adding this line
        Predicate equal = cb.equal( root.get( key ), val ); // <-- And using val instead of value
        predicateList.add( equal );
    }
    cq = cq.where( cb.and( predicateList.toArray( new Predicate[ predicateList.size() ] ) ) );
    return cq;
}