简体   繁体   中英

Segmentation fault, pointer issue

#include <stdio.h>
#include <stdlib.h>

typedef struct lista_inteiros
{
    int valor;
    struct lista_inteiros *next;

}element_int;

void insere_inteiro(element_int **head, element_int **aux, int m);
void remove_inteiro(element_int **head, element_int **aux, int m);

int main()
{
    int i = 0;
    element_int *head, *aux;

    head = NULL;

    for(i = 0; i<6; i++)
    {
        insere_inteiro(&head, &aux, i); 
    }

    aux = head;

    while(aux)
    {
        printf("%d\n", aux->valor);
        aux = aux->next;
    }

    aux = head;
    i = 4;

    remove_inteiro(&head, &aux, i);

    aux = head;
    while(aux)
    {
        printf("%d\n", aux->valor);
        aux = aux->next;
    }


    return 0;
}

void insere_inteiro(element_int **head, element_int **aux, int m)
{
    (*aux) = (element_int*)malloc(sizeof(element_int));
    if((*aux) == NULL)
    {
        printf("Error\n");
        exit(1);
    }

    (*aux)->valor = m;
    (*aux)->next = (*head);
    (*head) = (*aux);
}

void remove_inteiro(element_int **head, element_int **aux, int m)
{
    element_int *del;

    while((*aux) != NULL)
    {
        if((*head)->valor == m)
        {
            (*head) = (*head)->next;
            free(aux);
            (*aux) = (*head);
        }

        else if((*aux)->next->valor == m)
        {
            del = (*aux)->next;
            (*aux)->next = del->next;
            free(del);
        }
        (*aux) = (*aux)->next;
    }
}

Baiscally, this prints:

5
4
3
2
1
0
Segmentation Fault

And i really cant figure out why. It is supposed to eliminate the number 4, and then print the numbers again. So the desired output is:

5
4
3
2
1
0
5
3
2
1
0

The function insere_inteiro creates a new element and the function remove_inteiro removes one.

Each element of the list has a integer called valor .

您可以在else if((*aux)->next->valor == m)取消引用下一个值,而不检查是否存在

You dereference NULL, here's a fixed version:

#include <stdio.h>
#include <stdlib.h>

typedef struct lista_inteiros
{
    int valor;
    struct lista_inteiros *next;

}element_int;

void insere_inteiro(element_int **head, element_int **aux, int m);
void remove_inteiro(element_int **head, element_int **aux, int m);

int main()
{
    int i = 0;
    element_int *head, *aux;

    head = NULL;

    for(i = 0; i<6; i++)
    {
        insere_inteiro(&head, &aux, i);
    }

    aux = head;

    while(aux)
    {
        printf("%d\n", aux->valor);
        aux = aux->next;
    }

    aux = head;
    i = 4;

    remove_inteiro(&head, &aux, i);

    aux = head;
    while(aux)
    {
        printf("%d\n", aux->valor);
        aux = aux->next;
    }


    return 0;
}

void insere_inteiro(element_int **head, element_int **aux, int m)
{
    (*aux) = (element_int*)malloc(sizeof(element_int));
    if((*aux) == NULL)
    {
        printf("Error\n");
        exit(1);
    }

    (*aux)->valor = m;
    (*aux)->next = (*head);
    (*head) = (*aux);
}

void remove_inteiro(element_int **head, element_int **aux, int m)
{
    element_int *del;

    while((*aux) != NULL)
    {
        if((*head)->valor == m)
        {
            (*head) = (*head)->next;
            free(aux);
            (*aux) = (*head);
        }

/* CHANGED BELOW TO CHECK FOR NULL BEFORE DEREFERENCE */

        else if(((*aux)->next != NULL) && ((*aux)->next->valor == m))
        {
            del = (*aux)->next;
            (*aux)->next = del->next;
            free(del);
        }

        (*aux) = (*aux)->next;
    }
}

The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.

 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM