Beginner - Java Programming While Loop

Question

This code keeps on looping every time I enter something. How to fix it?

public void inputPlayer()
{
    Scanner input = new Scanner(System.in);
    while(name.length() < 1)
    {
        System.out.println("Name: ");
        this.setName(input.nextLine());
        //name = input.nextLine();

        if(name.length() < 1)
            System.err.println("Must have one or more characters");
    }
}

Heres' a screenshot of the whole thing:

Answer 1

The problem is visible in the screenshot, and is with your setName() method, which is currently:

public void setName(String newName) {
    newName = name;
}

The assignment is the wrong way around, so you never update your name field. It should be name = newName; .

Answer 2

because your setName function is wrong

it should be:

    public void setName(String newName) {
        name = newName;
    }

you put newName = name;